Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 869613003: [PATCH 5/11] ozone: evdev: Replace dispatch callbacks with an interface (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Replace dispatch callbacks with an interface This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. Rather than binding a large number of callbacks for every device, pass a single new object DeviceEventDispatcherEvdev to each device. BUG=449710 TEST=boot link_freon & move mouse Committed: https://crrev.com/e5feb802754ffd223e4b4098bd4c1b562a23062c Cr-Commit-Position: refs/heads/master@{#313524}

Patch Set 1 #

Patch Set 2 : updates for events_unittests #

Total comments: 1

Patch Set 3 : update per comments on previous patches #

Patch Set 4 : namespace ui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -490 lines) Patch
M ui/events/ozone/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/events/ozone/evdev/device_event_dispatcher_evdev.h View 1 2 3 8 chunks +19 lines, -37 lines 0 comments Download
A + ui/events/ozone/evdev/device_event_dispatcher_evdev.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.h View 2 chunks +10 lines, -13 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 1 2 5 chunks +9 lines, -11 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 2 chunks +6 lines, -17 lines 0 comments Download
M ui/events/ozone/evdev/event_dispatch_callback.h View 1 2 2 chunks +0 lines, -121 lines 0 comments Download
D ui/events/ozone/evdev/event_dispatch_callback.cc View 1 2 1 chunk +0 lines, -101 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 4 chunks +18 lines, -9 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 11 chunks +30 lines, -43 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 3 chunks +7 lines, -15 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 2 9 chunks +13 lines, -19 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.h View 2 chunks +11 lines, -12 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 1 3 chunks +7 lines, -14 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 2 23 chunks +84 lines, -60 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
spang
5 years, 11 months ago (2015-01-23 21:58:33 UTC) #2
alexst (slow to review)
lgtm https://codereview.chromium.org/869613003/diff/20001/ui/events/ozone/evdev/device_event_dispatcher_evdev.h File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right): https://codereview.chromium.org/869613003/diff/20001/ui/events/ozone/evdev/device_event_dispatcher_evdev.h#newcode79 ui/events/ozone/evdev/device_event_dispatcher_evdev.h:79: } // namespace // namspace ui
5 years, 10 months ago (2015-01-27 18:50:30 UTC) #3
spang
5 years, 10 months ago (2015-01-27 19:33:46 UTC) #4
spang
On 2015/01/27 18:50:30, alexst wrote: > lgtm > > https://codereview.chromium.org/869613003/diff/20001/ui/events/ozone/evdev/device_event_dispatcher_evdev.h > File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right): > ...
5 years, 10 months ago (2015-01-28 15:52:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869613003/60001
5 years, 10 months ago (2015-01-28 15:52:28 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-28 16:40:02 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 16:41:19 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e5feb802754ffd223e4b4098bd4c1b562a23062c
Cr-Commit-Position: refs/heads/master@{#313524}

Powered by Google App Engine
This is Rietveld 408576698