Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 869483003: Reverse logic of window / tab control in bookmark app creation. (Closed)

Created:
5 years, 11 months ago by benwells
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reverse logic of window / tab control in bookmark app creation. The option is now 'open as window', before it was 'open as tab'. The default has also been changed so by default the checkbox is unchecked (and the bookmark app will open as a tab). BUG=450102 Committed: https://crrev.com/a74227892c867e3b709b87e76c51f0cd764cc73b Cr-Commit-Position: refs/heads/master@{#313164}

Patch Set 1 #

Patch Set 2 : Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/launch_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
Did you mean to send this CL out for review or are you holding off ...
5 years, 11 months ago (2015-01-22 23:15:20 UTC) #2
benwells
On 2015/01/22 23:15:20, Lei Zhang wrote: > Did you mean to send this CL out ...
5 years, 11 months ago (2015-01-22 23:32:31 UTC) #3
benwells
Ready now.
5 years, 11 months ago (2015-01-23 01:41:09 UTC) #4
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-23 02:02:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869483003/20001
5 years, 11 months ago (2015-01-26 22:43:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 23:22:20 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 23:23:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a74227892c867e3b709b87e76c51f0cd764cc73b
Cr-Commit-Position: refs/heads/master@{#313164}

Powered by Google App Engine
This is Rietveld 408576698