chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h - Issue 869483003: Reverse logic of window / tab control in bookmark app creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h

Issue 869483003: Reverse logic of window / tab control in bookmark app creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h

diff --git a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h

index 1b4de061dfb988a22c241f03d689ac456a944862..0bdb2d5ad22e9e41e719253d53d1a0df36a05c55 100644

--- a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h

+++ b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h

@@ -93,8 +93,8 @@ class BookmarkAppBubbleView : public views::BubbleDelegateView,

// Button to close the window.

views::LabelButton* cancel_button_;

- // Checkbox to launch as a tab.

- views::Checkbox* open_as_tab_checkbox_;

+ // Checkbox to launch as a window.

+ views::Checkbox* open_as_window_checkbox_;

// Textfield showing the title of the app.

views::Textfield* title_tf_;

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc » ('j') | no next file with comments »