Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Side by Side Diff: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h

Issue 869483003: Reverse logic of window / tab control in bookmark app creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_BOOKMARK_APP_BUBBLE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_BOOKMARK_APP_BUBBLE_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_BOOKMARK_APP_BUBBLE_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_BOOKMARK_APP_BUBBLE_VIEW_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "chrome/browser/extensions/app_icon_loader.h" 10 #include "chrome/browser/extensions/app_icon_loader.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 86
87 // The extension id of the bookmark app. 87 // The extension id of the bookmark app.
88 const std::string extension_id_; 88 const std::string extension_id_;
89 89
90 // Button for removing the bookmark. 90 // Button for removing the bookmark.
91 views::LabelButton* add_button_; 91 views::LabelButton* add_button_;
92 92
93 // Button to close the window. 93 // Button to close the window.
94 views::LabelButton* cancel_button_; 94 views::LabelButton* cancel_button_;
95 95
96 // Checkbox to launch as a tab. 96 // Checkbox to launch as a window.
97 views::Checkbox* open_as_tab_checkbox_; 97 views::Checkbox* open_as_window_checkbox_;
98 98
99 // Textfield showing the title of the app. 99 // Textfield showing the title of the app.
100 views::Textfield* title_tf_; 100 views::Textfield* title_tf_;
101 101
102 // Image showing the icon of the app. 102 // Image showing the icon of the app.
103 views::ImageView* icon_image_view_; 103 views::ImageView* icon_image_view_;
104 104
105 // When the destructor is invoked should the app be removed? 105 // When the destructor is invoked should the app be removed?
106 bool remove_app_; 106 bool remove_app_;
107 107
108 // Used to load the icon. 108 // Used to load the icon.
109 scoped_ptr<extensions::AppIconLoader> app_icon_loader_; 109 scoped_ptr<extensions::AppIconLoader> app_icon_loader_;
110 110
111 DISALLOW_COPY_AND_ASSIGN(BookmarkAppBubbleView); 111 DISALLOW_COPY_AND_ASSIGN(BookmarkAppBubbleView);
112 }; 112 };
113 113
114 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_BOOKMARK_APP_BUBBLE_VIEW_H_ 114 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_BOOKMARK_APP_BUBBLE_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698