Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 868743002: Use SkXfermode::Mode in code related to Image. (Closed)

Created:
5 years, 11 months ago by dshwang
Modified:
5 years, 11 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, krit, kouhei+svg_chromium.org, dcheng, Dominik Röttsches, blink-reviews-html_chromium.org, rwlbuis, fs, slimming-paint-reviews_chromium.org, jbroman, danakj, dglazkov+blink, Rik, f(malita), gyuyoung.kim_webkit.org, blink-reviews-paint_chromium.org, Stephen Chennney, aandrey+blink_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use SkXfermode::Mode in code related to Image. BUG=425656 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188872

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Patch Set 3 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -119 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BoxPainter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 7 chunks +11 lines, -9 lines 0 comments Download
M Source/core/paint/ImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/TableCellPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/DragImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/GeneratedImage.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/GeneratedImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 2 3 chunks +6 lines, -9 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 7 chunks +10 lines, -22 lines 0 comments Download
M Source/platform/graphics/Image.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/Image.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/graphics/ImageBufferSurface.cpp View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/StaticBitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/StaticBitmapImage.cpp View 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/skia/NativeImageSkia.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/platform/graphics/skia/NativeImageSkia.cpp View 2 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
dshwang
could you review further clean-up?
5 years, 11 months ago (2015-01-22 17:12:33 UTC) #2
Justin Novosad
On 2015/01/22 17:12:33, dshwang wrote: > could you review further clean-up? lgtm
5 years, 11 months ago (2015-01-22 17:18:11 UTC) #3
dshwang
On 2015/01/22 17:18:11, junov wrote: > On 2015/01/22 17:12:33, dshwang wrote: > > could you ...
5 years, 11 months ago (2015-01-22 17:24:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868743002/20001
5 years, 11 months ago (2015-01-22 17:25:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102508)
5 years, 11 months ago (2015-01-22 18:51:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868743002/20001
5 years, 11 months ago (2015-01-22 18:55:59 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/platform/graphics/GraphicsContextTest.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 11 months ago (2015-01-22 19:26:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868743002/40001
5 years, 11 months ago (2015-01-22 21:07:47 UTC) #15
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-22 23:27:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868743002/40001
5 years, 11 months ago (2015-01-23 10:07:20 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 11:00:35 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188872

Powered by Google App Engine
This is Rietveld 408576698