Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 868453002: Rename is_visible to is_reflectable; use is_debuggable instead of is_reflectable (Closed)

Created:
5 years, 11 months ago by rmacnak
Modified:
5 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, hausner
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Rename is_visible to is_reflectable; use is_debuggable instead of is_reflectable to decide whether to filter a frame from stack traces. Merge verbose_stacktrace flag into show_hidden_frames. Don't mark native functions as non-debuggable (breakpoints don't actually work there now but nothing goes wrong). BUG= Committed: https://code.google.com/p/dart/source/detail?r=43121

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 3

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -50 lines) Patch
M runtime/lib/mirrors.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M runtime/lib/stacktrace.cc View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 1 chunk +21 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 8 chunks +8 lines, -11 lines 0 comments Download
M tests/language/vm/type_cast_vm_test.dart View 1 2 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 11 months ago (2015-01-22 22:55:03 UTC) #2
Ivan Posva
LGTMwC -ip https://codereview.chromium.org/868453002/diff/100001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/868453002/diff/100001/runtime/vm/debugger.cc#newcode908 runtime/vm/debugger.cc:908: if (FLAG_show_invisible_frames || frame->function().is_stacktrace_visible()) { Shouldn't we ...
5 years, 11 months ago (2015-01-23 19:37:07 UTC) #3
rmacnak
https://codereview.chromium.org/868453002/diff/100001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/868453002/diff/100001/runtime/vm/debugger.cc#newcode908 runtime/vm/debugger.cc:908: if (FLAG_show_invisible_frames || frame->function().is_stacktrace_visible()) { On 2015/01/23 19:37:07, Ivan ...
5 years, 11 months ago (2015-01-23 21:16:17 UTC) #4
rmacnak
5 years, 11 months ago (2015-01-23 21:16:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as 43121 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698