Rename is_visible to is_reflectable; use is_debuggable instead of is_reflectable

runtime/vm/debugger.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/debugger.h"
 
 #include "include/dart_api.h"
 
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
@@ skipping 887 matching lines @@
       VariableAt(v, &var_name, &unused, &unused, &var_value);
       jsvar.AddProperty("name", var_name.ToCString());
       jsvar.AddProperty("value", var_value);
     }
   }
 }
 
 
 
 void DebuggerStackTrace::AddActivation(ActivationFrame* frame) {
-  if (FLAG_show_invisible_frames || frame->function().is_visible()) {
+  if (FLAG_show_invisible_frames || frame->function().is_stacktrace_visible()) {

[Ivan Posva, 2015/01/23 19:37:07]

Shouldn't we just use is_debuggable() here instead of adding the alias
is_stacktrace_visible?

[rmacnak, 2015/01/23 21:16:17]

Yeah, flattened these out.

     trace_.Add(frame);
   }
 }
 
 
 const uint8_t kSafepointKind =
     RawPcDescriptors::kIcCall |  RawPcDescriptors::kOptStaticCall |
     RawPcDescriptors::kUnoptStaticCall | RawPcDescriptors::kClosureCall |
     RawPcDescriptors::kRuntimeCall;
 
@@ skipping 397 matching lines @@
   const Array& deopt_frame = Array::Handle();
   const intptr_t deopt_frame_offset = -1;
 
   for (intptr_t i = 0; i < ex_trace.Length(); i++) {
     function = ex_trace.FunctionAtFrame(i);
     // Pre-allocated Stacktraces may include empty slots, either (a) to indicate
     // where frames were omitted in the case a stack has more frames than the
     // pre-allocated trace (such as a stack overflow) or (b) because a stack has
     // fewer frames that the pre-allocated trace (such as memory exhaustion with
     // a shallow stack).
-    if (!function.IsNull() && function.is_visible()) {
+    if (!function.IsNull() && function.is_stacktrace_visible()) {
       code = ex_trace.CodeAtFrame(i);
       ASSERT(function.raw() == code.function());
       uword pc = code.EntryPoint() + Smi::Value(ex_trace.PcOffsetAtFrame(i));
       if (code.is_optimized() && ex_trace.expand_inlined()) {
         // Traverse inlined frames.
         for (InlinedFunctionsIterator it(code, pc); !it.Done(); it.Advance()) {
           function = it.function();
           code = it.code();
           ASSERT(function.raw() == code.function());
           uword pc = it.pc();
@@ skipping 1285 matching lines @@
 }
 
 
 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
   ASSERT(bpt->next() == NULL);
   bpt->set_next(code_breakpoints_);
   code_breakpoints_ = bpt;
 }
 
 }  // namespace dart