Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: runtime/lib/stacktrace.cc

Issue 868453002: Rename is_visible to is_reflectable; use is_debuggable instead of is_reflectable (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/stacktrace.cc
diff --git a/runtime/lib/stacktrace.cc b/runtime/lib/stacktrace.cc
index 3e02ca997d1a2174fe926b782a009079d3866189..6c40ecc58870e8d22bbbea2a8a629c80eeb63206 100644
--- a/runtime/lib/stacktrace.cc
+++ b/runtime/lib/stacktrace.cc
@@ -38,17 +38,13 @@ static void IterateFrames(const GrowableObjectArray& code_list,
ASSERT(frame != NULL); // We expect to find a dart invocation frame.
Code& code = Code::Handle();
Smi& offset = Smi::Handle();
- bool catch_frame_skipped = false; // Tracks if catch frame has been skipped.
+ intptr_t frames_to_skip = 2; // _setupFullStackTrace and the catch frame.
while (frame != NULL) {
if (frame->IsDartFrame()) {
code = frame->LookupDartCode();
offset = Smi::New(frame->pc() - code.EntryPoint());
- if (!catch_frame_skipped) {
- const Function& func = Function::Handle(code.function());
- // Skip over hidden native, and mark first visible frame as catch frame.
- if (func.is_visible()) {
- catch_frame_skipped = true;
- }
+ if (frames_to_skip > 0) {
+ frames_to_skip--;
} else {
code_list.Add(code);
pc_offset_list.Add(offset);
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698