Isolate courgette_unittests

Isolate courgette_unittests

Adding link to http://www.chromium.org/developers/testing/isolated-testing/for-swes for my future self.

R=maruel@chromium.org,jochen@chromium.org
TBR=jam@chromium.org
BUG=98637, 450912
Committed: https://crrev.com/c9bd3b9a5667a36c05592ec9d16533be91b4567c
Cr-Commit-Position: refs/heads/master@{#312531}

Committed: https://crrev.com/c82c93910b9dd6328ff3fb7f0f2f8f8add764840
Cr-Commit-Position: refs/heads/master@{#312665}

[M-A Ruel, 2015-01-22 00:36:08]

https://chromium-swarm.appspot.com/user/tasks?limit=100&sort=created_ts&state...

They never triggered because I renamed the OS names a long time ago and had
forgot to update the doc.

I updated
https://sites.google.com/a/chromium.org/dev/developers/testing/isolated-testi...
to use the right dimensions.

But you can just send try jobs, it'll use swarming underneat as you updated the
json files.

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
File courgette/courgette_unittests.isolate (right):

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
courgette/courgette_unittests.isolate:11:
'<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
I guess this test needs neither xvfb nor google test specific hacks.

[scottmg, 2015-01-22 00:40:02]

On 2015/01/22 00:36:08, M-A Ruel wrote:
>
https://chromium-swarm.appspot.com/user/tasks?limit=100&sort=created_ts&state...
> 
> They never triggered because I renamed the OS names a long time ago and had
> forgot to update the doc.
> 
> I updated
>
https://sites.google.com/a/chromium.org/dev/developers/testing/isolated-testi...
> to use the right dimensions.
> 
> But you can just send try jobs, it'll use swarming underneat as you updated
the
> json files.

Ah, ok, thanks.

> 
>
https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
> File courgette/courgette_unittests.isolate (right):
> 
>
https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
> courgette/courgette_unittests.isolate:11:
> '<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
> I guess this test needs neither xvfb nor google test specific hacks.

[scottmg, 2015-01-22 00:40:06]

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
File courgette/courgette_unittests.isolate (right):

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
courgette/courgette_unittests.isolate:11:
'<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
On 2015/01/22 00:36:08, M-A Ruel wrote:
> I guess this test needs neither xvfb nor google test specific hacks.

It only runs on Windows, so not xvfb. I'm not sure what the google test hacks
are. Is that --brave-new-test-launcher goop in some other .isolate files? I
don't know how to decide if want that?

[M-A Ruel, 2015-01-22 00:45:58]

lgtm if it passes try jobs.

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
File courgette/courgette_unittests.isolate (right):

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
courgette/courgette_unittests.isolate:11:
'<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
On 2015/01/22 00:40:06, scottmg wrote:
> On 2015/01/22 00:36:08, M-A Ruel wrote:
> > I guess this test needs neither xvfb nor google test specific hacks.
> 
> It only runs on Windows, so not xvfb. I'm not sure what the google test hacks
> are. Is that --brave-new-test-launcher goop in some other .isolate files? I
> don't know how to decide if want that?

https://chromium.googlesource.com/chromium/src.git/+/master/testing/test_env.py

- sandbox
- asan
- python stuff

nothing needed, that's fine.

[scottmg, 2015-01-22 00:52:43]

On 2015/01/22 00:45:58, M-A Ruel wrote:
> lgtm if it passes try jobs.
> 
>
https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
> File courgette/courgette_unittests.isolate (right):
> 
>
https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
> courgette/courgette_unittests.isolate:11:
> '<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
> On 2015/01/22 00:40:06, scottmg wrote:
> > On 2015/01/22 00:36:08, M-A Ruel wrote:
> > > I guess this test needs neither xvfb nor google test specific hacks.
> > 
> > It only runs on Windows, so not xvfb. I'm not sure what the google test
hacks
> > are. Is that --brave-new-test-launcher goop in some other .isolate files? I
> > don't know how to decide if want that?
> 
>
https://chromium.googlesource.com/chromium/src.git/+/master/testing/test_env.py
> 
> - sandbox
> - asan
> - python stuff
> 
> nothing needed, that's fine.

I see, thanks.

[M-A Ruel, 2015-01-22 00:58:34]

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
File courgette/courgette_unittests.isolate (right):

https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
courgette/courgette_unittests.isolate:11:
'<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
On 2015/01/22 00:40:06, scottmg wrote:
> It only runs on Windows.

Why is it built on all platforms then?

[scottmg, 2015-01-22 01:05:58]

On 2015/01/22 00:58:34, M-A Ruel wrote:
>
https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
> File courgette/courgette_unittests.isolate (right):
> 
>
https://codereview.chromium.org/868433002/diff/1/courgette/courgette_unittest...
> courgette/courgette_unittests.isolate:11:
> '<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
> On 2015/01/22 00:40:06, scottmg wrote:
> > It only runs on Windows.
> 
> Why is it built on all platforms then?

No idea! It seems to be built everywhere, but only run on waterfall on Windows.
Seems like a bug or maybe it only compiles but doesn't work correctly.

[scottmg, 2015-01-22 01:29:18]

win_chromium_rel_ng looks ok, so going to CQ.

[scottmg, 2015-01-22 01:29:27]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-01-22 01:31:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868433002/1

[commit-bot: I haz the power, 2015-01-22 02:22:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-22 02:24:48]

Patchset 1 (id:??) landed as
https://crrev.com/c9bd3b9a5667a36c05592ec9d16533be91b4567c
Cr-Commit-Position: refs/heads/master@{#312531}

[kochi, 2015-01-22 06:07:18]

On 2015/01/22 02:24:48, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c9bd3b9a5667a36c05592ec9d16533be91b4567c
> Cr-Commit-Position: refs/heads/master@{#312531}

Looks like the change is incomplete: see crbug.com/450912

I'll try reverting this.

[kochi, 2015-01-22 06:08:45]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/865133002/ by kochi@chromium.org.

The reason for reverting is: http://crbug.com/450912

courget_unittests is failing on Win7(dbg) bots since build#34639.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28....

[scottmg, 2015-01-22 18:38:16]

Relanding with include of base.isolate for shared_library (which was causing
Debug to fail on Windows).

[scottmg, 2015-01-22 18:38:19]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-01-22 18:39:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868433002/20001

[commit-bot: I haz the power, 2015-01-22 20:19:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-22 20:21:25]

Patchset 2 (id:??) landed as
https://crrev.com/c82c93910b9dd6328ff3fb7f0f2f8f8add764840
Cr-Commit-Position: refs/heads/master@{#312665}