courgette/courgette_unittests.isolate - Issue 868433002: Isolate courgette_unittests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: courgette/courgette_unittests.isolate

Issue 868433002: Isolate courgette_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'variables': {

	6 'files': [

	7 '<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',

	8 'testdata/',

	9 ],

	10 'command': [

	11 '<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)',
	M-A Ruel 2015/01/22 00:36:08 I guess this test needs neither xvfb nor google te I guess this test needs neither xvfb nor google test specific hacks. scottmg 2015/01/22 00:40:06 It only runs on Windows, so not xvfb. I'm not sure Show quoted text On 2015/01/22 00:36:08, M-A Ruel wrote: > I guess this test needs neither xvfb nor google test specific hacks. It only runs on Windows, so not xvfb. I'm not sure what the google test hacks are. Is that --brave-new-test-launcher goop in some other .isolate files? I don't know how to decide if want that? M-A Ruel 2015/01/22 00:45:58 https://chromium.googlesource.com/chromium/src.git Show quoted text On 2015/01/22 00:40:06, scottmg wrote: > On 2015/01/22 00:36:08, M-A Ruel wrote: > > I guess this test needs neither xvfb nor google test specific hacks. > > It only runs on Windows, so not xvfb. I'm not sure what the google test hacks > are. Is that --brave-new-test-launcher goop in some other .isolate files? I > don't know how to decide if want that? https://chromium.googlesource.com/chromium/src.git/+/master/testing/test_env.py - sandbox - asan - python stuff nothing needed, that's fine. M-A Ruel 2015/01/22 00:58:34 Why is it built on all platforms then? Show quoted text On 2015/01/22 00:40:06, scottmg wrote: > It only runs on Windows. Why is it built on all platforms then?
	12 ],

	13 },

	14 }

OLD	NEW

« no previous file with comments | « courgette/courgette.gyp ('k') | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »