Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 868263002: Sky shouldn't crash on device rotate (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Sky shouldn't crash on device rotate There were two problems (both fixed in this CL): 1) When we were resized by the view manager, we forgot to deflate by the device-pixel-ratio when converting to engine types. That caused use to allocate a backing texture that was 9x what we needed. 2) When the surfaces system returned textures to us for re-use, we'd put them into the cache even if they were the old size. That caused us to thrash the texture cache. In this CL, we make the size of the textures in the cache explicit. R=eseidel@chromium.org BUG=449001 Committed: https://chromium.googlesource.com/external/mojo/+/bbef272e3930b827b836dc3b03a903ecc3c0b20e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -17 lines) Patch
M mojo/converters/geometry/geometry_type_converters.h View 2 chunks +16 lines, -0 lines 0 comments Download
M sky/compositor/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/compositor/resource_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/compositor/resource_manager.cc View 2 chunks +5 lines, -12 lines 0 comments Download
A sky/compositor/texture_cache.h View 1 chunk +35 lines, -0 lines 0 comments Download
A sky/compositor/texture_cache.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-24 00:40:26 UTC) #1
eseidel
lgtm
5 years, 11 months ago (2015-01-24 00:41:57 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-24 05:20:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbef272e3930b827b836dc3b03a903ecc3c0b20e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698