Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868253003: Also catch devtools_http.DevToolsClientConnectionError. (Closed)

Created:
5 years, 11 months ago by achuithb
Modified:
5 years, 11 months ago
Reviewers:
chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also catch devtools_http.DevToolsClientConnectionError. BUG=450278 TEST=cros unittests Committed: https://crrev.com/14bbb218d326586af69fc34c0ea2cb65e8e88b62 Cr-Commit-Position: refs/heads/master@{#313395}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py View 1 2 chunks +5 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
achuithb
Chris, please take a look.
5 years, 11 months ago (2015-01-27 02:21:07 UTC) #2
chrishenry
lgtm https://codereview.chromium.org/868253003/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py File tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py (right): https://codereview.chromium.org/868253003/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py#newcode64 tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py:64: devtools_http.DevToolsClientConnectionError): Can you add a TODO(chrishenry): This exception ...
5 years, 11 months ago (2015-01-27 17:54:23 UTC) #3
achuithb
Thank you https://codereview.chromium.org/868253003/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py File tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py (right): https://codereview.chromium.org/868253003/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py#newcode64 tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py:64: devtools_http.DevToolsClientConnectionError): On 2015/01/27 17:54:23, chrishenry wrote: > ...
5 years, 11 months ago (2015-01-27 22:09:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868253003/20001
5 years, 11 months ago (2015-01-27 22:13:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 23:15:41 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 23:16:26 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/14bbb218d326586af69fc34c0ea2cb65e8e88b62
Cr-Commit-Position: refs/heads/master@{#313395}

Powered by Google App Engine
This is Rietveld 408576698