Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py

Issue 868253003: Also catch devtools_http.DevToolsClientConnectionError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add TODO Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py b/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
index 97b01276dd85356b7581161e936cfbee641e9bdf..480d09590798d6d63ae855e821e822944d90641f 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
from telemetry.core import exceptions
+from telemetry.core.backends.chrome_inspector import devtools_http
from telemetry.core.backends.chrome_inspector import inspector_backend_list
from telemetry.core.backends.chrome import oobe
@@ -21,9 +22,8 @@ class MiscWebContentsBackend(inspector_backend_list.InspectorBackendList):
"""Lightweight property to determine if the oobe webui is visible."""
try:
return bool(len(self))
- except (exceptions.BrowserGoneException,
- exceptions.BrowserConnectionGoneException,
- exceptions.DevtoolsTargetCrashException):
+ except (exceptions.AppCrashException,
+ devtools_http.DevToolsClientConnectionError):
return False
def GetOobe(self):
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698