Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py

Issue 868253003: Also catch devtools_http.DevToolsClientConnectionError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add TODO Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py
index ec718dbf880bfebeb05f0deba15e2228d489d927..aeda1d2594ef68ccff8ceb883fb857d4767c51ae 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py
@@ -8,6 +8,7 @@ from telemetry import decorators
from telemetry.core import exceptions
from telemetry.core import util
from telemetry.core.backends.chrome import cros_test_case
+from telemetry.core.backends.chrome_inspector import devtools_http
class CrOSCryptohomeTest(cros_test_case.CrOSTestCase):
@@ -59,8 +60,10 @@ class CrOSLoginTest(cros_test_case.CrOSTestCase):
extension = self._GetAutotestExtension(b)
try:
extension.ExecuteJavaScript('chrome.autotestPrivate.logout();')
- except (exceptions.BrowserConnectionGoneException,
- exceptions.BrowserGoneException):
+ # TODO(chrishenry): crbug.com/450278. DevToolsClientConnectionError
+ # should probably be caught at a lower-level.
+ except (exceptions.AppCrashException,
+ devtools_http.DevToolsClientConnectionError):
pass
util.WaitFor(lambda: not self._IsCryptohomeMounted(), 20)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698