Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 868203003: De-Client CommandBuffer interface (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@fix_sample_app
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

De-Client CommandBuffer interface This removes the CommandBufferClient interface from mojo.CommandBuffer. It had two methods on it: *) DidDestroy() which is redundant with the pipe closing, removed. *) DidLoseContext(uint32 reason) which is used to signal an error code prior to the pipe closing. Replaced with an observer interface. BUG=451319 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fb327165a721c9279d478f982f6f41d83512e9fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M mojo/gles2/command_buffer_client_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M mojo/services/gpu/public/interfaces/command_buffer.mojom View 2 chunks +10 lines, -8 lines 0 comments Download
M services/gles2/command_buffer_driver.h View 3 chunks +6 lines, -7 lines 0 comments Download
M services/gles2/command_buffer_driver.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M services/gles2/command_buffer_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M services/gles2/command_buffer_impl.cc View 6 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
(picking you somewhat arbitrarily as reviewer here, feel free to defer if you'd like me ...
5 years, 10 months ago (2015-01-30 01:38:11 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-01-30 18:47:30 UTC) #3
jamesr
5 years, 10 months ago (2015-01-30 21:12:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb327165a721c9279d478f982f6f41d83512e9fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698