Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1573)

Unified Diff: mojo/services/gpu/public/interfaces/command_buffer.mojom

Issue 868203003: De-Client CommandBuffer interface (Closed) Base URL: git@github.com:domokit/mojo.git@fix_sample_app
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/gles2/command_buffer_client_impl.cc ('k') | services/gles2/command_buffer_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/gpu/public/interfaces/command_buffer.mojom
diff --git a/mojo/services/gpu/public/interfaces/command_buffer.mojom b/mojo/services/gpu/public/interfaces/command_buffer.mojom
index a31b3dde3ecf5ffb79cd7c815a67725ff80d61e8..aa2c5567eb9da0caba34f3420ade2384b2150033 100644
--- a/mojo/services/gpu/public/interfaces/command_buffer.mojom
+++ b/mojo/services/gpu/public/interfaces/command_buffer.mojom
@@ -25,10 +25,19 @@ interface CommandBufferSyncPointClient {
DidInsertSyncPoint(uint32 sync_point);
};
-[Client=CommandBufferClient]
+interface CommandBufferLostContextObserver {
+ DidLoseContext(int32 context_lost_reason);
+};
+
interface CommandBuffer {
+ // Initialize attempts to initialize the command buffer. Success or failure
+ // will be communicated via the CommandBufferSyncClient DidInitialize() call.
+ // If the context is lost after creation the LostContext method on the
+ // CommandBufferLostContextObserver's will be called then this pipe will be
+ // closed.
Initialize(CommandBufferSyncClient sync_client,
CommandBufferSyncPointClient sync_point_client,
+ CommandBufferLostContextObserver lost_observer,
handle<shared_buffer> shared_state);
SetGetBuffer(int32 buffer);
Flush(int32 put_offset);
@@ -43,11 +52,4 @@ interface CommandBuffer {
InsertSyncPoint(bool retire);
RetireSyncPoint(uint32 sync_point);
Echo() => ();
-
- // TODO(piman): sync points
-};
-
-interface CommandBufferClient {
- DidDestroy();
- LostContext(int32 lost_reason); // TODO(piman): enum
};
« no previous file with comments | « mojo/gles2/command_buffer_client_impl.cc ('k') | services/gles2/command_buffer_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698