Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: services/gles2/command_buffer_driver.h

Issue 868203003: De-Client CommandBuffer interface (Closed) Base URL: git@github.com:domokit/mojo.git@fix_sample_app
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/gpu/public/interfaces/command_buffer.mojom ('k') | services/gles2/command_buffer_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/gles2/command_buffer_driver.h
diff --git a/services/gles2/command_buffer_driver.h b/services/gles2/command_buffer_driver.h
index f157ca63f809b71ce036447e796e0c884c67bb8b..3c855a7ca7d81be6bb1dd348843e0193bf66bebc 100644
--- a/services/gles2/command_buffer_driver.h
+++ b/services/gles2/command_buffer_driver.h
@@ -37,13 +37,10 @@ class CommandBufferDriver {
public:
class Client {
public:
- virtual void DidDestroy() = 0;
+ virtual ~Client();
virtual void UpdateVSyncParameters(base::TimeTicks timebase,
base::TimeDelta interval) = 0;
- virtual void LostContext(int32_t lost_reason) = 0;
-
- protected:
- virtual ~Client();
+ virtual void DidLoseContext() = 0;
};
// Offscreen.
CommandBufferDriver(gfx::GLShareGroup* share_group,
@@ -57,9 +54,10 @@ class CommandBufferDriver {
gpu::SyncPointManager* sync_point_manager);
~CommandBufferDriver();
- void set_client(Client* client) { client_ = client; }
+ void set_client(scoped_ptr<Client> client) { client_ = client.Pass(); }
void Initialize(mojo::CommandBufferSyncClientPtr sync_client,
+ mojo::CommandBufferLostContextObserverPtr loss_observer,
mojo::ScopedSharedBufferHandle shared_state);
void SetGetBuffer(int32_t buffer);
void Flush(int32_t put_offset);
@@ -80,8 +78,9 @@ class CommandBufferDriver {
void OnUpdateVSyncParameters(const base::TimeTicks timebase,
const base::TimeDelta interval);
- Client* client_;
+ scoped_ptr<Client> client_;
mojo::CommandBufferSyncClientPtr sync_client_;
+ mojo::CommandBufferLostContextObserverPtr loss_observer_;
gfx::AcceleratedWidget widget_;
gfx::Size size_;
scoped_ptr<gpu::CommandBufferService> command_buffer_;
« no previous file with comments | « mojo/services/gpu/public/interfaces/command_buffer.mojom ('k') | services/gles2/command_buffer_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698