Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 868023003: Never (re)start NavigatorGamepad platform event updating once detached. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
haraken, Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Never (re)start NavigatorGamepad platform event updating once detached. Extend r187811 to always apply; notifications (event listener additions or page visibility) may in boundary cases also be delivered once we are in a frame-detached state. Do not (re)start platform event updating in that case, as the follow-on sampling depends on being in a non-detached state. This is (flakily) invariant on Oilpan being enabled, or not. R=haraken BUG=357071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. An older problem, not due to the switch made in https://codereview.chromium.org/826223002
5 years, 11 months ago (2015-01-23 13:18:55 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-23 14:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868023003/1
5 years, 11 months ago (2015-01-23 15:04:46 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 16:05:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188893

Powered by Google App Engine
This is Rietveld 408576698