Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 826223002: Remove DOMWindowLifecycleObserver::window() (Closed)

Created:
5 years, 11 months ago by haraken
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, sof
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove DOMWindowLifecycleObserver::window() This is a preparation for landing https://codereview.chromium.org/822863003/. I'm planning to make LocalDOMWindow's destruction unobservable because the timing becomes undeterministic in a GC system. This CL removes DOMWindowLifecycleObserver::window(), which is a method whose behavior depends on a timing of LocalDOMWindow's destruction. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187750

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M Source/core/frame/DOMWindowLifecycleObserver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleObserver.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
PTAL
5 years, 11 months ago (2014-12-29 15:28:15 UTC) #2
sof
https://codereview.chromium.org/826223002/diff/1/Source/modules/gamepad/NavigatorGamepad.cpp File Source/modules/gamepad/NavigatorGamepad.cpp (right): https://codereview.chromium.org/826223002/diff/1/Source/modules/gamepad/NavigatorGamepad.cpp#newcode100 Source/modules/gamepad/NavigatorGamepad.cpp:100: if (frame()->domWindow()) { Add "frame() &&" to prevent detached ...
5 years, 11 months ago (2014-12-29 15:32:38 UTC) #3
haraken
On 2014/12/29 15:32:38, sof wrote: > https://codereview.chromium.org/826223002/diff/1/Source/modules/gamepad/NavigatorGamepad.cpp > File Source/modules/gamepad/NavigatorGamepad.cpp (right): > > https://codereview.chromium.org/826223002/diff/1/Source/modules/gamepad/NavigatorGamepad.cpp#newcode100 > ...
5 years, 11 months ago (2014-12-29 16:42:07 UTC) #4
sof
lgtm
5 years, 11 months ago (2014-12-29 16:49:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826223002/20001
5 years, 11 months ago (2014-12-29 17:08:55 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2014-12-29 18:31:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187750

Powered by Google App Engine
This is Rietveld 408576698