Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 867773002: Revert of Add more trace events to "benchmark" category (Closed)

Created:
5 years, 11 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jdduke+watch_chromium.org, tdresser+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, James Su, scheduler-bugs_chromium.org, Rick Byers, jdduke (slow), ernstm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add more trace events to "benchmark" category (patchset #4 id:50001 of https://codereview.chromium.org/855553002/) Reason for revert: This CL has perf implication and currently all the android perf bots are red. So lets delay the landing until we get perf bots back to normal Original issue's description: > Add more trace events to "benchmark" category > > This is to make the trace events captured during smoothness test more > useful in debugging smoothness/latency issues. > > These added trace events are supposed to be giving most useful information > about the input/scheduling/rendering pipeline and have low occurrence in > each frame so as to minimize the performance overhead. > > Following are the list for the added trace events roughly in the order > of the input->rendering pipeline: > > LatencyInfo.Flow // so we can follow the input latency flow > RenderWidgetHostViewAndroid::OnVSync // when frame is started > InputHandlerProxy::HandleInputEvent // when the input event is handled on impl > RenderWidget::OnHandleInputEvent // when the input event is handled on main > Scheduler::BeginFrame // cc decides to schedule a frame > Scheduler::BeginRetroFrame // cc starts a retro frame > Scheduler::BeginImplFrame // impl frame is scheduled > Scheduler::OnBeginImplFrameDeadline // impl frame actually starts > OnSwapCompositorFrame // browser gets notified that renderer frame is ready > CompositorImpl::PostComposit // browser schedules a frame > SingleThreadProxy::CompositeImmediately // browser starts a frame > SingleThreadProxy::DidSwapBuffersCompleteOnImplThread // browser frame is done > > BUG=449258 > > Committed: https://crrev.com/0190b029a83fad58e31a039bd8bba62d9d12ee5a > Cr-Commit-Position: refs/heads/master@{#312664} TBR=sievers@chromium.org,brianderson@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449258 Committed: https://crrev.com/ef1c46ab8a359ae309b49b3222c10bb2ef0bcf09 Cr-Commit-Position: refs/heads/master@{#312668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M cc/scheduler/scheduler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/latency_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yufeng Shen (Slow to review)
Created Revert of Add more trace events to "benchmark" category
5 years, 11 months ago (2015-01-22 20:24:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867773002/1
5 years, 11 months ago (2015-01-22 20:24:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 20:26:18 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 20:27:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef1c46ab8a359ae309b49b3222c10bb2ef0bcf09
Cr-Commit-Position: refs/heads/master@{#312668}

Powered by Google App Engine
This is Rietveld 408576698