Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 855553002: Add more trace events to "benchmark" category (Closed)

Created:
5 years, 11 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jdduke+watch_chromium.org, tdresser+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, James Su, scheduler-bugs_chromium.org, Rick Byers, jdduke (slow), ernstm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more trace events to "benchmark" category This is to make the trace events captured during smoothness test more useful in debugging smoothness/latency issues. These added trace events are supposed to be giving most useful information about the input/scheduling/rendering pipeline and have low occurrence in each frame so as to minimize the performance overhead. Following are the list for the added trace events roughly in the order of the input->rendering pipeline: LatencyInfo.Flow // so we can follow the input latency flow RenderWidgetHostViewAndroid::OnVSync // when frame is started InputHandlerProxy::HandleInputEvent // when the input event is handled on impl RenderWidget::OnHandleInputEvent // when the input event is handled on main Scheduler::BeginFrame // cc decides to schedule a frame Scheduler::BeginRetroFrame // cc starts a retro frame Scheduler::BeginImplFrame // impl frame is scheduled Scheduler::OnBeginImplFrameDeadline // impl frame actually starts OnSwapCompositorFrame // browser gets notified that renderer frame is ready CompositorImpl::PostComposit // browser schedules a frame SingleThreadProxy::CompositeImmediately // browser starts a frame SingleThreadProxy::DidSwapBuffersCompleteOnImplThread // browser frame is done BUG=449258 Committed: https://crrev.com/0190b029a83fad58e31a039bd8bba62d9d12ee5a Cr-Commit-Position: refs/heads/master@{#312664}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix typo #

Total comments: 1

Patch Set 4 : add tracing to ThreadProxy::DidSwapBuffersCompleteOnImplThread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M cc/scheduler/scheduler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/latency_info.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Yufeng Shen (Slow to review)
Daniel, Sami and Brian, Do you guys feel these added traces are useful in debugging ...
5 years, 11 months ago (2015-01-15 20:48:40 UTC) #2
Sami
These look like a reasonable set of events to add without introducing too much overhead. ...
5 years, 11 months ago (2015-01-19 11:32:44 UTC) #3
Yufeng Shen (Slow to review)
On 2015/01/19 11:32:44, Sami wrote: > These look like a reasonable set of events to ...
5 years, 11 months ago (2015-01-19 18:31:04 UTC) #4
brianderson
lgtm https://codereview.chromium.org/855553002/diff/40001/cc/trees/single_thread_proxy.cc File cc/trees/single_thread_proxy.cc (right): https://codereview.chromium.org/855553002/diff/40001/cc/trees/single_thread_proxy.cc#newcode484 cc/trees/single_thread_proxy.cc:484: "SingleThreadProxy::DidSwapBuffersCompleteOnImplThread"); Can you also add this for the ...
5 years, 11 months ago (2015-01-21 10:26:22 UTC) #5
Yufeng Shen (Slow to review)
On 2015/01/21 10:26:22, brianderson wrote: > lgtm > > https://codereview.chromium.org/855553002/diff/40001/cc/trees/single_thread_proxy.cc > File cc/trees/single_thread_proxy.cc (right): > ...
5 years, 11 months ago (2015-01-21 16:31:13 UTC) #6
no sievers
lgtm
5 years, 11 months ago (2015-01-22 19:36:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855553002/50001
5 years, 11 months ago (2015-01-22 19:46:36 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 11 months ago (2015-01-22 20:18:51 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0190b029a83fad58e31a039bd8bba62d9d12ee5a Cr-Commit-Position: refs/heads/master@{#312664}
5 years, 11 months ago (2015-01-22 20:19:41 UTC) #11
Yufeng Shen (Slow to review)
5 years, 11 months ago (2015-01-22 20:24:00 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:50001) has been created in
https://codereview.chromium.org/867773002/ by miletus@chromium.org.

The reason for reverting is: This CL has perf implication and currently all the
android perf bots are red.

So lets delay the landing until we get perf bots back to normal.

Powered by Google App Engine
This is Rietveld 408576698