Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 867483004: Work around GCC bug in constexpr to attributes (Closed)

Created:
5 years, 10 months ago by JF
Modified:
5 years, 10 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Work around GCC bug in constexpr to attributes __attribute__((aligned(MaxCacheLineSize))) triggers a GCC bug because enum {MaxCacheLineSize = 64 }; isn't constant enough. Adding zero to it makes it that much more constant. R= stichnot@chromium.org BUG= https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55382 Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=867684e23582f2ff6aeeb045709a7066defe218f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/IceDefs.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
JF
5 years, 10 months ago (2015-01-28 23:07:16 UTC) #1
JF
Committed patchset #1 (id:1) manually as 867684e23582f2ff6aeeb045709a7066defe218f (presubmit successful).
5 years, 10 months ago (2015-01-28 23:07:42 UTC) #2
Jim Stichnoth
5 years, 10 months ago (2015-01-28 23:08:40 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698