Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: src/IceDefs.h

Issue 867483004: Work around GCC bug in constexpr to attributes (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceDefs.h
diff --git a/src/IceDefs.h b/src/IceDefs.h
index d327ea63e453b110620882fb0b1ba59fd7843d4d..e7d97dbc981c87845b5310f090609a633dfe6665 100644
--- a/src/IceDefs.h
+++ b/src/IceDefs.h
@@ -129,8 +129,10 @@ typedef uint32_t TimerIdT;
enum { MaxCacheLineSize = 64 };
// Use ICE_CACHELINE_BOUNDARY to force the next field in a declaration
// list to be aligned to the next cache line.
+// Note: zero is added to work around the following GCC 4.8 bug (fixed in 4.9):
+// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55382
#define ICE_CACHELINE_BOUNDARY \
- __attribute__((aligned(MaxCacheLineSize))) int : 0
+ __attribute__((aligned(MaxCacheLineSize + 0))) int : 0
// PNaCl is ILP32, so theoretically we should only need 32-bit offsets.
typedef int32_t RelocOffsetT;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698