Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 866893003: Enable visibleOnAllWorkspaces on stable. (Closed)

Created:
5 years, 10 months ago by jackhou1
Modified:
5 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable visibleOnAllWorkspaces on stable. BUG=384644 Committed: https://crrev.com/8cf22f4bc9e53ecbcd71e2736f6df5aa600997ba Cr-Commit-Position: refs/heads/master@{#313855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js View 2 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/browser/app_window/native_app_window.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/_api_features.json View 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/common/api/app_window.idl View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jackhou1
5 years, 10 months ago (2015-01-29 00:28:23 UTC) #2
benwells
lgtm
5 years, 10 months ago (2015-01-29 01:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866893003/1
5 years, 10 months ago (2015-01-29 03:00:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/28352)
5 years, 10 months ago (2015-01-29 04:33:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866893003/1
5 years, 10 months ago (2015-01-30 01:07:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 01:37:36 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 01:39:13 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8cf22f4bc9e53ecbcd71e2736f6df5aa600997ba
Cr-Commit-Position: refs/heads/master@{#313855}

Powered by Google App Engine
This is Rietveld 408576698