Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 866893003: Enable visibleOnAllWorkspaces on stable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/app_window/app_window_api.cc
diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc
index 263ae00659fa9bfcc49d67d9accfbaa5b8da2466..e70934bb27d08e2c61a43fa621791281e7fdcf54 100644
--- a/extensions/browser/api/app_window/app_window_api.cc
+++ b/extensions/browser/api/app_window/app_window_api.cc
@@ -57,8 +57,6 @@ const char kAlphaEnabledMissingPermission[] =
"The alphaEnabled option requires app.window.alpha permission.";
const char kAlphaEnabledNeedsFrameNone[] =
"The alphaEnabled option can only be used with \"frame: 'none'\".";
-const char kVisibleOnAllWorkspacesWrongChannel[] =
- "The visibleOnAllWorkspaces option requires dev channel or newer.";
const char kImeWindowMissingPermission[] =
"Extensions require the \"app.window.ime\" permission to create windows.";
const char kImeOptionIsNotSupported[] =
@@ -310,10 +308,6 @@ bool AppWindowCreateFunction::RunAsync() {
create_params.focused = *options->focused.get();
if (options->visible_on_all_workspaces.get()) {
- if (AppWindowClient::Get()->IsCurrentChannelOlderThanDev()) {
- error_ = app_window_constants::kVisibleOnAllWorkspacesWrongChannel;
- return false;
- }
create_params.visible_on_all_workspaces =
*options->visible_on_all_workspaces.get();
}

Powered by Google App Engine
This is Rietveld 408576698