Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js

Issue 866893003: Enable visibleOnAllWorkspaces on stable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/app_window/app_window_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js
diff --git a/chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js b/chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js
index b996cf0d2725005d26b85f8125e9e70d423f527f..7420400433ce2953869099747681a56acc567525 100644
--- a/chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js
+++ b/chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js
@@ -4,8 +4,6 @@
// All these tests are run in Stable channel.
-var error = "The visibleOnAllWorkspaces option requires dev channel or newer.";
-
chrome.app.runtime.onLaunched.addListener(function() {
chrome.test.runTests([
@@ -14,13 +12,13 @@ chrome.app.runtime.onLaunched.addListener(function() {
chrome.app.window.create(
'index.html', {
visibleOnAllWorkspaces: true,
- }, chrome.test.callbackFail(error));
+ }, chrome.test.callbackPass(function () {}));
},
// Check chrome.app.window.canSetVisibleOnAllWorkspaces().
function testCanSetVisibleOnAllWorkspaces() {
chrome.test.assertTrue(
- chrome.app.window.canSetVisibleOnAllWorkspaces === undefined);
+ typeof chrome.app.window.canSetVisibleOnAllWorkspaces == 'function');
chrome.test.callbackPass(function () {})();
},
« no previous file with comments | « no previous file | extensions/browser/api/app_window/app_window_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698