Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 865163003: bookmarks: Move BookmarkNode into 'bookmarks' namespace. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
Joao da Silva, sky, Ian Wen
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, blundell, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bookmarks: Move BookmarkNode into 'bookmarks' namespace. BUG=370433 TEST=unit_tests, components_unittests R=sky@chromium.org TBR=joaodasilva@chromium.org (for policy) Committed: https://crrev.com/a665b308ea4c6c7e75f56a4c614d279c0d25e64a Cr-Commit-Position: refs/heads/master@{#314653}

Patch Set 1 #

Patch Set 2 : linux #

Patch Set 3 : android #

Patch Set 4 : cocoa #

Patch Set 5 : mac fixes #

Total comments: 10

Patch Set 6 : review fixes #

Patch Set 7 : enhanced_bookmarks fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+734 lines, -525 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.h View 1 2 3 4 5 2 chunks +23 lines, -21 lines 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_reader.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_reader.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.h View 1 2 3 4 5 3 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/provider/bookmark_model_observer_task.h View 1 2 3 4 5 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/android/provider/bookmark_model_observer_task.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_stats.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_stats.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.h View 1 5 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 1 9 chunks +32 lines, -30 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.h View 1 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.h View 1 3 chunks +52 lines, -54 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_errors_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_drag_drop.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_drag_drop.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_editor.h View 1 4 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_editor.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.h View 1 7 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h View 1 3 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_item_applescript.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_item_applescript.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.h View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h View 1 2 3 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 2 3 7 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 1 2 3 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.h View 1 2 3 4 5 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h View 1 2 3 9 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h View 1 2 3 7 chunks +22 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h View 1 2 3 3 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.h View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.h View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.mm View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell_unittest.mm View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 4 chunks +25 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.h View 1 5 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h View 1 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 1 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_index.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_match.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M components/bookmarks/browser/bookmark_node.h View 3 chunks +4 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_node.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.h View 2 chunks +1 line, -1 line 0 comments Download
M components/bookmarks/test/bookmark_test_helpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_image_service.h View 1 2 3 4 5 3 chunks +15 lines, -10 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_image_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_cluster_service.h View 2 chunks +7 lines, -6 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_cluster_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_search_service.h View 3 chunks +7 lines, -5 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_search_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_service.h View 1 2 3 4 5 3 chunks +7 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.h View 1 2 3 4 5 6 9 chunks +41 lines, -37 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_observer.h View 1 2 3 4 5 3 chunks +11 lines, -6 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils.h View 1 2 3 4 5 1 chunk +9 lines, -8 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/enhanced_bookmarks/metadata_accessor.h View 3 chunks +11 lines, -11 lines 0 comments Download
M components/enhanced_bookmarks/metadata_accessor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/browser/managed_bookmarks_tracker.h View 1 2 3 4 5 5 chunks +8 lines, -6 lines 1 comment Download
M components/policy/core/browser/managed_bookmarks_tracker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/core/browser/managed_bookmarks_tracker_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
tfarina
Oh man! That was insane!! :/ I'm fixing the mac failures and will fix until ...
5 years, 10 months ago (2015-02-03 02:28:32 UTC) #1
sky
LGTM with the following fixes. Make sure you don't have any other weird header guards. ...
5 years, 10 months ago (2015-02-03 17:08:37 UTC) #2
tfarina
https://codereview.chromium.org/865163003/diff/80001/components/enhanced_bookmarks/bookmark_image_service.h File components/enhanced_bookmarks/bookmark_image_service.h (right): https://codereview.chromium.org/865163003/diff/80001/components/enhanced_bookmarks/bookmark_image_service.h#newcode184 components/enhanced_bookmarks/bookmark_image_service.h:184: #endif // COMPONENTS_ENHANCED_BOOKMARKS_BOOKMARK_IMAGE_SERVICE_H_/home/tfarina/chromium/src/buildtools/linux64/clang-format On 2015/02/03 17:08:37, sky wrote: > ...
5 years, 10 months ago (2015-02-04 20:51:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865163003/100001
5 years, 10 months ago (2015-02-04 20:51:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40470)
5 years, 10 months ago (2015-02-04 21:00:21 UTC) #7
tfarina
TBRing Joao for components/policy!
5 years, 10 months ago (2015-02-04 21:04:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865163003/100001
5 years, 10 months ago (2015-02-04 21:05:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865163003/120001
5 years, 10 months ago (2015-02-04 21:10:31 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 10 months ago (2015-02-04 22:11:24 UTC) #14
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/a665b308ea4c6c7e75f56a4c614d279c0d25e64a Cr-Commit-Position: refs/heads/master@{#314653}
5 years, 10 months ago (2015-02-04 22:12:29 UTC) #15
Ian Wen
Hello tfarina@, it will be so considerate of you if you add ianwen@chromium.org to be ...
5 years, 10 months ago (2015-02-05 00:27:19 UTC) #17
Joao da Silva
5 years, 10 months ago (2015-02-05 10:12:58 UTC) #18
Message was sent while issue was closed. 
policy/ lgtm but note that I'm not in the owners list anymore :-)

Please add mnissler@chromium.org for future policy/ reviews.

https://codereview.chromium.org/865163003/diff/120001/components/policy/core/...
File components/policy/core/browser/managed_bookmarks_tracker.h (right):

https://codereview.chromium.org/865163003/diff/120001/components/policy/core/...
components/policy/core/browser/managed_bookmarks_tracker.h:82: 
nit: remove this newline in some future CL

Powered by Google App Engine
This is Rietveld 408576698