Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3600)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h

Issue 865163003: bookmarks: Move BookmarkNode into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enhanced_bookmarks fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h
index 3652a534842fb91a227d07752aa2086cca04912f..2e18f7d351e604ffd81f04b13eac4ca2c504f10b 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h
@@ -14,9 +14,12 @@
#import "base/mac/scoped_nsobject.h"
#include "ui/base/window_open_disposition.h"
-class BookmarkNode;
class BookmarkMenuBridge;
+namespace bookmarks {
+class BookmarkNode;
+}
+
@interface BookmarkMenuCocoaController : NSObject<NSMenuDelegate> {
@private
BookmarkMenuBridge* bridge_; // weak; owns me
@@ -28,10 +31,10 @@ class BookmarkMenuBridge;
// Return an autoreleased string to be used as a menu title for the
// given bookmark node.
-+ (NSString*)menuTitleForNode:(const BookmarkNode*)node;
++ (NSString*)menuTitleForNode:(const bookmarks::BookmarkNode*)node;
// Make a relevant tooltip string for node.
-+ (NSString*)tooltipForNode:(const BookmarkNode*)node;
++ (NSString*)tooltipForNode:(const bookmarks::BookmarkNode*)node;
- (id)initWithBridge:(BookmarkMenuBridge *)bridge
andMenu:(NSMenu*)menu;
@@ -47,8 +50,8 @@ class BookmarkMenuBridge;
@interface BookmarkMenuCocoaController (ExposedForUnitTests)
-- (const BookmarkNode*)nodeForIdentifier:(int)identifier;
-- (void)openURLForNode:(const BookmarkNode*)node;
+- (const bookmarks::BookmarkNode*)nodeForIdentifier:(int)identifier;
+- (void)openURLForNode:(const bookmarks::BookmarkNode*)node;
- (void)openAll:(NSInteger)tag
withDisposition:(WindowOpenDisposition)disposition;
@end // BookmarkMenuCocoaController (ExposedForUnitTests)

Powered by Google App Engine
This is Rietveld 408576698