chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h - Issue 865163003: bookmarks: Move BookmarkNode into 'bookmarks' namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h

Issue 865163003: bookmarks: Move BookmarkNode into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enhanced_bookmarks fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc ('k') | chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc » ('j') | components/policy/core/browser/managed_bookmarks_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h

diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h

index 55b4bd6025f5f4454d23402b0416630e14489bd3..e3b42fe8ab6563d4f67367d3db08b31c31cf3e6a 100644

--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h

+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h

@@ -32,7 +32,7 @@ class BookmarkContextMenuControllerDelegate {

// Sent before any command from the menu is executed.

virtual void WillExecuteCommand(

int command_id,

- const std::vector<const BookmarkNode*>& bookmarks) {}

+ const std::vector<const bookmarks::BookmarkNode*>& bookmarks) {}

// Sent after any command from the menu is executed.

virtual void DidExecuteCommand(int command_id) {}

@@ -56,8 +56,8 @@ class BookmarkContextMenuController

Browser* browser,

Profile* profile,

content::PageNavigator* navigator,

- const BookmarkNode* parent,

- const std::vector<const BookmarkNode*>& selection);

+ const bookmarks::BookmarkNode* parent,

+ const std::vector<const bookmarks::BookmarkNode*>& selection);

~BookmarkContextMenuController() override;

ui::SimpleMenuModel* menu_model() { return menu_model_.get(); }

@@ -95,8 +95,8 @@ class BookmarkContextMenuController

Browser* browser_;

Profile* profile_;

content::PageNavigator* navigator_;

- const BookmarkNode* parent_;

- std::vector<const BookmarkNode*> selection_;

+ const bookmarks::BookmarkNode* parent_;

+ std::vector<const bookmarks::BookmarkNode*> selection_;

bookmarks::BookmarkModel* model_;

scoped_ptr<ui::SimpleMenuModel> menu_model_;