Remove createUncachedTexture function, attempt to recycle scratch in createTexture.

One createTexture function, attempt to recycle scratch in createTexture.

Committed: https://skia.googlesource.com/skia/+/d0423587ac56ae84d3f1eb796d5c1e2dfba9646e

[bsalomon, 2015-02-05 16:59:22]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-02-05 20:43:49]

lgtm + some questions

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGpuDevice.cpp#...
src/gpu/SkGpuDevice.cpp:199: 
Is the loss of Exact important here?

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGr.cpp#newcode182
src/gpu/SkGr.cpp:182: GrTexture* result = ctx->createTexture(desc, true, pixels,
rowBytes);
result && ?

https://codereview.chromium.org/864383003/diff/40001/src/gpu/effects/GrConfig...
File src/gpu/effects/GrConfigConversionEffect.cpp (right):

https://codereview.chromium.org/864383003/diff/40001/src/gpu/effects/GrConfig...
src/gpu/effects/GrConfigConversionEffect.cpp:187: 
Did you intentionally make these budgeted?

[bsalomon, 2015-02-06 15:26:18]

New patchsets have been uploaded after l-g-t-m from robertphillips@google.com

[bsalomon, 2015-02-06 15:27:27]

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGpuDevice.cpp#...
src/gpu/SkGpuDevice.cpp:199: 
On 2015/02/05 20:43:49, robertphillips wrote:
> Is the loss of Exact important here?

createTexture() will return an exact match texture.

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/864383003/diff/40001/src/gpu/SkGr.cpp#newcode182
src/gpu/SkGr.cpp:182: GrTexture* result = ctx->createTexture(desc, true, pixels,
rowBytes);
On 2015/02/05 20:43:49, robertphillips wrote:
> result && ?

Done.

https://codereview.chromium.org/864383003/diff/40001/src/gpu/effects/GrConfig...
File src/gpu/effects/GrConfigConversionEffect.cpp (right):

https://codereview.chromium.org/864383003/diff/40001/src/gpu/effects/GrConfig...
src/gpu/effects/GrConfigConversionEffect.cpp:187: 
On 2015/02/05 20:43:49, robertphillips wrote:
> Did you intentionally make these budgeted?

Yeah, I think they should count.

[bsalomon, 2015-02-06 16:12:36]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-02-06 16:12:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864383003/60001

[commit-bot: I haz the power, 2015-02-06 16:16:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 16:16:46]

Try jobs failed on following builders:
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86...)

[bsalomon, 2015-02-06 16:43:42]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-02-06 16:44:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864383003/60001

[commit-bot: I haz the power, 2015-02-06 16:49:29]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d0423587ac56ae84d3f1eb796d5c1e2dfba9646e