src/effects/SkColorCubeFilter.cpp - Issue 864383003: Remove createUncachedTexture function, attempt to recycle scratch in createTexture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkColorCubeFilter.cpp

Issue 864383003: Remove createUncachedTexture function, attempt to recycle scratch in createTexture. (Closed) Base URL: https://skia.googlesource.com/skia.git@continue

Patch Set: Comments, fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkColorCubeFilter.cpp

diff --git a/src/effects/SkColorCubeFilter.cpp b/src/effects/SkColorCubeFilter.cpp

index f4ffefc8891284f9e6eec28997b6de57b1c16c75..df9f5ea6efbac8811bebfcfa107a102bbbbb3152 100644

--- a/src/effects/SkColorCubeFilter.cpp

+++ b/src/effects/SkColorCubeFilter.cpp

@@ -356,7 +356,7 @@ GrFragmentProcessor* SkColorCubeFilter::asFragmentProcessor(GrContext* context)

SkAutoTUnref<GrTexture> textureCube(context->findAndRefCachedTexture(key));

if (!textureCube) {

- textureCube.reset(context->createTexture(desc, fCubeData->data(), 0));

+ textureCube.reset(context->createTexture(desc, true, fCubeData->data(), 0));

if (textureCube) {

SkAssertResult(context->addResourceToCache(key, textureCube));

}

« no previous file with comments | « src/effects/SkBlurMaskFilter.cpp ('k') | src/gpu/GrContext.cpp » ('j') | no next file with comments »