Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 864193002: Disable -Wl,-z,defs on mipsel to suppress ffmpeg error (Closed)

Created:
5 years, 11 months ago by jamesr
Modified:
5 years, 11 months ago
Reviewers:
Nico, Zachary Kuznia
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable -Wl,-z,defs on mipsel to suppress ffmpeg error The ffmpeg build on mips is broken which manifests in build errors when z,defs is specified. The owners of this build would like the compile time error to be suppressed for now while they work on a proper fix. BUG=450771, 371125 Committed: https://crrev.com/9267528ad62c796f30c9f51f398fbfa29f0232a1 Cr-Commit-Position: refs/heads/master@{#312557}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix sense of test, rebase on top of sanitizer check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
jamesr
5 years, 11 months ago (2015-01-22 02:02:36 UTC) #2
Nico
https://codereview.chromium.org/864193002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/864193002/diff/1/build/config/compiler/BUILD.gn#newcode308 build/config/compiler/BUILD.gn:308: if (cpu_arch == "mipsel") { !=, not ==, no? ...
5 years, 11 months ago (2015-01-22 02:05:25 UTC) #3
jamesr
On 2015/01/22 02:05:25, Nico wrote: > https://codereview.chromium.org/864193002/diff/1/build/config/compiler/BUILD.gn > File build/config/compiler/BUILD.gn (right): > > https://codereview.chromium.org/864193002/diff/1/build/config/compiler/BUILD.gn#newcode308 > ...
5 years, 11 months ago (2015-01-22 02:06:30 UTC) #4
jamesr
ptal
5 years, 11 months ago (2015-01-22 02:08:42 UTC) #5
Nico
On 2015/01/22 02:08:42, jamesr wrote: > ptal Lgmt!
5 years, 11 months ago (2015-01-22 02:13:33 UTC) #6
Nico
On 2015/01/22 02:13:33, Nico wrote: > On 2015/01/22 02:08:42, jamesr wrote: > > ptal > ...
5 years, 11 months ago (2015-01-22 02:13:45 UTC) #7
Zachary Kuznia
lgtm
5 years, 11 months ago (2015-01-22 02:16:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864193002/20001
5 years, 11 months ago (2015-01-22 03:01:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 03:49:34 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9267528ad62c796f30c9f51f398fbfa29f0232a1 Cr-Commit-Position: refs/heads/master@{#312557}
5 years, 11 months ago (2015-01-22 03:50:20 UTC) #12
jamesr
5 years, 11 months ago (2015-01-27 20:26:38 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/873313007/ by jamesr@chromium.org.

The reason for reverting is: ffmpeg issue was fixed here:
https://gerrit.chromium.org/gerrit/#/c/73566/ which was rolled into chromium
here: https://crrev.com/313130.

Powered by Google App Engine
This is Rietveld 408576698