Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 864193002: Disable -Wl,-z,defs on mipsel to suppress ffmpeg error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 if (cpu_arch == "arm") { 6 if (cpu_arch == "arm") {
7 import("//build/config/arm.gni") 7 import("//build/config/arm.gni")
8 } 8 }
9 if (is_posix) { 9 if (is_posix) {
10 import("//build/config/gcc/gcc_version.gni") 10 import("//build/config/gcc/gcc_version.gni")
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 cflags += [ 294 cflags += [
295 "-fPIC", 295 "-fPIC",
296 "-pipe", # Use pipes for communicating between sub-processes. Faster. 296 "-pipe", # Use pipes for communicating between sub-processes. Faster.
297 ] 297 ]
298 298
299 ldflags += [ 299 ldflags += [
300 "-fPIC", 300 "-fPIC",
301 "-Wl,-z,noexecstack", 301 "-Wl,-z,noexecstack",
302 "-Wl,-z,now", 302 "-Wl,-z,now",
303 "-Wl,-z,relro", 303 "-Wl,-z,relro",
304 "-Wl,-z,defs",
305 ] 304 ]
305
306 # TODO(zork): The mipsel build is broken in ffmpeg, guard this flag for now
307 # to hide the breakage. https://crbug.com/450771
308 if (cpu_arch == "mipsel") {
Nico 2015/01/22 02:05:25 !=, not ==, no? Also, this probably conflicts with
309 ldflags += [ "-Wl,-z,defs" ]
310 }
306 } 311 }
307 312
308 # Linux-specific compiler flags setup. 313 # Linux-specific compiler flags setup.
309 # ------------------------------------ 314 # ------------------------------------
310 if (is_linux) { 315 if (is_linux) {
311 cflags += [ "-pthread" ] 316 cflags += [ "-pthread" ]
312 ldflags += [ "-pthread" ] 317 ldflags += [ "-pthread" ]
313 } 318 }
314 if (use_gold) { 319 if (use_gold) {
315 gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin", 320 gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin",
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 cflags += [ "-gsplit-dwarf" ] 992 cflags += [ "-gsplit-dwarf" ]
988 } 993 }
989 } 994 }
990 } 995 }
991 996
992 config("no_symbols") { 997 config("no_symbols") {
993 if (!is_win) { 998 if (!is_win) {
994 cflags = [ "-g0" ] 999 cflags = [ "-g0" ]
995 } 1000 }
996 } 1001 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698