build/config/compiler/BUILD.gn - Issue 864193002: Disable -Wl,-z,defs on mipsel to suppress ffmpeg error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 864193002: Disable -Wl,-z,defs on mipsel to suppress ffmpeg error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix sense of test, rebase on top of sanitizer check Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index d929781d2564ee22a1200014167dd356ecaf7525..a1d68e97b40004ce2d40a14cf9f241e83b1af135 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -302,7 +302,10 @@ config("compiler") {

"-Wl,-z,now",

"-Wl,-z,relro",

]

- if (!using_sanitizer) {

+ # TODO(zork): The mipsel build is broken in ffmpeg, guard this flag for now

+ # to hide the breakage. https://crbug.com/450771

+ if (!using_sanitizer && cpu_arch != "mipsel") {

ldflags += [ "-Wl,-z,defs" ]

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »