Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 863243005: DM::SKPSrc::size() reports correct size. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM::SKPSrc::size() reports correct size. Also, DM::GPUSink and DM::RasterSink crop DM::Src::size() to 2048x2048. Motivation: Improve PDF testing by printing the entire SKP. Source: http://crrev.com/863243004 BUG=skia:3365 Committed: https://skia.googlesource.com/skia/+/441b10eac09a1f44983e35da827a6b438a409e63 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot,Test-ChromeOS-Alex-GMA3150-x86-Release-Trybot Committed: https://skia.googlesource.com/skia/+/d4dd58e43ca4551531ad6a9f54bfc5632ea45a80

Patch Set 1 #

Patch Set 2 : fixes for low-ram machines #

Patch Set 3 : while #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M dm/DMSrcSink.cpp View 1 2 5 chunks +21 lines, -7 lines 0 comments Download
M gm/gm.h View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
hal.canary
lgtm
5 years, 10 months ago (2015-01-28 19:04:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863243005/1
5 years, 10 months ago (2015-01-28 19:04:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/441b10eac09a1f44983e35da827a6b438a409e63
5 years, 10 months ago (2015-01-28 19:12:29 UTC) #5
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/884743003/ by mtklein@google.com. ...
5 years, 10 months ago (2015-01-28 20:03:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863243005/40001
5 years, 10 months ago (2015-01-28 21:49:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/d4dd58e43ca4551531ad6a9f54bfc5632ea45a80
5 years, 10 months ago (2015-01-28 21:59:45 UTC) #9
mtklein
5 years, 10 months ago (2015-01-28 23:31:31 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/886543005/ by mtklein@google.com.

The reason for reverting is: Still no good on Chrome OS bot:

http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Alex-GMA3150-x....

Powered by Google App Engine
This is Rietveld 408576698