Make WebThreadedDataReceiver wrap a Blink-managed object instead.

Make WebThreadedDataReceiver wrap a Blink-managed object instead.

Separate the embedder view of a 'threaded data receiver' and the Blink
implementation, including where it is allocated and managed, by having
WebThreadedDataReceiver use a WebPrivatePtr<> to wrap the Blink object.

In order to support this, WebPrivatePtr<> can now wrap an Oilpan
GC mixin object also.

TBR=jochen,tkent
BUG=398076
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188941

[sof, 2015-01-24 19:23:42]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-01-24 19:23:42]

Please take a look.

[haraken, 2015-01-26 01:47:03]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-01-26 01:47:04]

LGTM

https://codereview.chromium.org/863113004/diff/40001/Source/core/html/parser/...
File Source/core/html/parser/ThreadedDataReceiver.h (right):

https://codereview.chromium.org/863113004/diff/40001/Source/core/html/parser/...
Source/core/html/parser/ThreadedDataReceiver.h:21: #endif

I wonder why you need to define ref() and deref() here (and thus need to
override ref() and deref() in ParserDataReceiver).

[haraken, 2015-01-26 01:47:07]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-01-26 01:47:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863113004/40001

[commit-bot: I haz the power, 2015-01-26 01:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-26 01:53:32]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[sof, 2015-01-26 06:14:21]

https://codereview.chromium.org/863113004/diff/40001/Source/core/html/parser/...
File Source/core/html/parser/ThreadedDataReceiver.h (right):

https://codereview.chromium.org/863113004/diff/40001/Source/core/html/parser/...
Source/core/html/parser/ThreadedDataReceiver.h:21: #endif
On 2015/01/26 01:47:04, haraken wrote:
> 
> I wonder why you need to define ref() and deref() here (and thus need to
> override ref() and deref() in ParserDataReceiver).

WebThreadedDataReceiver::WebPrivatePtr<> wraps a ThreadedDataReceiver, so it
needs to have the refcounting pair of methods available non-Oilpan.

I don't know the planned set of implementations of this interface (besides this
one), so that seemed tidiest. If ParserDataReceiver is the only one, we can
simplify and just have the WebThreadedDataReceiver delegate calls to it &
shorten out this interface (and its mixin + ref-forwarding trickery.)

[sof, 2015-01-26 06:16:42]

sigbjornf@opera.com changed reviewers:
+ jochen@chromium.org, tkent@chromium.org

[sof, 2015-01-26 06:16:42]

Thanks for the review.

TBRing the public/ changes (jochen, tkent: ptal?), so as to unbreak the builds.

[sof, 2015-01-26 06:16:53]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-01-26 06:17:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863113004/40001

[commit-bot: I haz the power, 2015-01-26 06:21:16]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188941

[haraken, 2015-01-26 06:25:31]

https://codereview.chromium.org/863113004/diff/40001/Source/core/html/parser/...
File Source/core/html/parser/ThreadedDataReceiver.h (right):

https://codereview.chromium.org/863113004/diff/40001/Source/core/html/parser/...
Source/core/html/parser/ThreadedDataReceiver.h:21: #endif
On 2015/01/26 06:14:20, sof wrote:
> On 2015/01/26 01:47:04, haraken wrote:
> > 
> > I wonder why you need to define ref() and deref() here (and thus need to
> > override ref() and deref() in ParserDataReceiver).
> 
> WebThreadedDataReceiver::WebPrivatePtr<> wraps a ThreadedDataReceiver, so it
> needs to have the refcounting pair of methods available non-Oilpan.
> 
> I don't know the planned set of implementations of this interface (besides
this
> one), so that seemed tidiest. If ParserDataReceiver is the only one, we can
> simplify and just have the WebThreadedDataReceiver delegate calls to it &
> shorten out this interface (and its mixin + ref-forwarding trickery.)

Thanks, makes sense.