public/platform/WebPrivatePtr.h - Issue 863113004: Make WebThreadedDataReceiver wrap a Blink-managed object instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebPrivatePtr.h

Issue 863113004: Make WebThreadedDataReceiver wrap a Blink-managed object instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix msvc compilation Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebPrivatePtr.h

diff --git a/public/platform/WebPrivatePtr.h b/public/platform/WebPrivatePtr.h

index 07b84db35c5dccc9f6e46def38fbe1f358cb8d75..0c9b7aaadf60357baf9bf01283a52b1b5298e2cb 100644

--- a/public/platform/WebPrivatePtr.h

+++ b/public/platform/WebPrivatePtr.h

@@ -50,7 +50,7 @@ enum LifetimeManagementType {

template<typename T>

class LifetimeOf {

- static const bool isGarbageCollected = WTF::IsSubclassOfTemplate<T, GarbageCollected>::value;

+ static const bool isGarbageCollected = WTF::IsSubclassOfTemplate<T, GarbageCollected>::value || WTF::IsSubclass<T, GarbageCollectedMixin>::value;

static const bool isRefCountedGarbageCollected = WTF::IsSubclassOfTemplate<T, RefCountedGarbageCollected>::value;

public:

static const LifetimeManagementType value =

« Source/core/html/parser/ThreadedDataReceiver.h ('K') | « Source/web/web.gypi ('k') | public/platform/WebThreadedDataReceiver.h » ('j') | no next file with comments »