Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: Source/core/html/parser/ThreadedDataReceiver.h

Issue 863113004: Make WebThreadedDataReceiver wrap a Blink-managed object instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix msvc compilation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/parser/HTMLDocumentParser.cpp ('k') | Source/core/loader/DocumentLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/ThreadedDataReceiver.h
diff --git a/public/platform/WebThreadedDataReceiver.h b/Source/core/html/parser/ThreadedDataReceiver.h
similarity index 54%
copy from public/platform/WebThreadedDataReceiver.h
copy to Source/core/html/parser/ThreadedDataReceiver.h
index 516c13b870bc61b75e539c13ee153172a7cafa3c..e0aaeed8359a8159645cfb5642751b1d80b1e654 100644
--- a/public/platform/WebThreadedDataReceiver.h
+++ b/Source/core/html/parser/ThreadedDataReceiver.h
@@ -1,25 +1,32 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef WebThreadedDataReceiver_h
-#define WebThreadedDataReceiver_h
+#ifndef ThreadedDataReceiver_h
+#define ThreadedDataReceiver_h
+
+#include "platform/heap/Handle.h"
namespace blink {
class WebThread;
-class WebThreadedDataReceiver {
+class ThreadedDataReceiver : public WillBeGarbageCollectedMixin {
public:
+ virtual ~ThreadedDataReceiver() { }
+
+#if !ENABLE(OILPAN)
+ virtual void ref() = 0;
+ virtual void deref() = 0;
+#endif
haraken 2015/01/26 01:47:04 I wonder why you need to define ref() and deref()
sof 2015/01/26 06:14:20 WebThreadedDataReceiver::WebPrivatePtr<> wraps a T
haraken 2015/01/26 06:25:30 Thanks, makes sense.
+
virtual void acceptData(const char* data, int dataLength) = 0;
virtual WebThread* backgroundThread() = 0;
virtual bool needsMainthreadDataCopy() = 0;
virtual void acceptMainthreadDataNotification(const char* data, int dataLength, int encodedDataLength) = 0;
-
- virtual ~WebThreadedDataReceiver() { }
};
} // namespace blink
-#endif
+#endif // ThreadedDataReceiver_h
« no previous file with comments | « Source/core/html/parser/HTMLDocumentParser.cpp ('k') | Source/core/loader/DocumentLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698