Issue 863093002: Enable -Werror for LLVM build

Issue 863093002: Enable -Werror for LLVM build (Closed)

Created:
5 years, 11 months ago by JF

Modified:
5 years, 10 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Enable -Werror for LLVM build We're often added warnings to our build without realizing it, having -Werror will catch these. R=dschuff@chromium.org TEST= git cl try Committed: https://chromium.googlesource.com/native_client/src/native_client/+/959566135dff83b7bcd6a98adf28bbec859060cb

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -23 lines)			Patch
	M	toolchain_build/toolchain_build_pnacl.py	View	1 2 3 4 5	5 chunks	+36 lines, -23 lines	0 comments	Download

Total messages: 9 (0 generated)

Unused variables warnings fixed in: https://codereview.chromium.org/858393002

5 years, 11 months ago (2015-01-22 00:01:10 UTC) #3

More fixes: - LLVM: https://codereview.chromium.org/867013002 - Subzero: https://codereview.chromium.org/862853003/

5 years, 11 months ago (2015-01-22 22:13:54 UTC) #4

More fixes were pulled in by this COMPONENT_REVISION update: https://codereview.chromium.org/873443004/ I think this will be ...

5 years, 11 months ago (2015-01-26 20:50:09 UTC) #5

Yet another fix for the Windows build: https://codereview.chromium.org/875043005/

5 years, 11 months ago (2015-01-27 04:37:24 UTC) #6

Another Windows fix: https://codereview.chromium.org/862943009/ I don't get how MinGW's GCC 4.8.1 is so sad. Maybe ...

5 years, 11 months ago (2015-01-27 17:30:15 UTC) #7

On 2015/01/27 17:30:15, JF wrote: > Another Windows fix: > https://codereview.chromium.org/862943009/ > > I don't ...

5 years, 11 months ago (2015-01-27 22:40:49 UTC) #8

5 years, 10 months ago (2015-01-29 05:21:03 UTC) #9

Message was sent while issue was closed.

Committed patchset #6 (id:100001) manually as
959566135dff83b7bcd6a98adf28bbec859060cb (presubmit successful).