Issue 858393002: Remove unused variable warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 858393002: Remove unused variable warning (Closed)

Created:
5 years, 11 months ago by JF

Modified:
5 years, 11 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove unused variable warning I'm trying to enable -Werror: https://codereview.chromium.org/863093002 Our localmods are creating warnings. Mark the variables as used. R=dschuff@chromium.org NOTRY=true Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=d836f2c1d98fe68ef620f75a71de07418f51fa6a

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	lib/Target/X86/X86ISelLowering.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

5 years, 11 months ago (2015-01-22 00:35:14 UTC) #5

Committed patchset #1 (id:1) manually as d836f2c1d98fe68ef620f75a71de07418f51fa6a (presubmit successful).

5 years, 11 months ago (2015-01-22 00:36:03 UTC) #6

5 years, 11 months ago (2015-01-22 00:36:40 UTC) #7

Message was sent while issue was closed.

On 2015/01/22 00:35:14, I haz the power (commit-bot) wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Maybe I will! Maybe I will...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages