Issue 867013002: Fix more build warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 867013002: Fix more build warnings (Closed)

Created:
5 years, 11 months ago by JF

Modified:
5 years, 11 months ago

Reviewers:
kschimpf, Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix more build warnings The following CL enables -Werror: https://codereview.chromium.org/863093002/ There were two warnings left in our LLVM build: - The ObjDump private member was unused. - GCC 4.8 on Windows thinks the function can fallthrough when it actually can't (because all cases are handled). R=dschuff@chromium.org, kschimpf@chromium.org TEST= make check BUG= none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=2c57bd8daeb691d8f25298b359b07ff9a1ea3d23

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	lib/Bitcode/NaCl/Analysis/NaClObjDump.cpp	View		2 chunks	+1 line, -5 lines	0 comments	Download
	M	lib/Bitcode/NaCl/Reader/NaClBitCodes.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

5 years, 11 months ago (2015-01-22 22:35:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2c57bd8daeb691d8f25298b359b07ff9a1ea3d23 (presubmit successful).