cc: Split RasterTilePriorityQueue into required and all based on type.

cc: Split RasterTilePriorityQueue into required and all based on type.

This patch splits raster tile priority queue into two: required and all.
The required queue is used when the only tiles that we need are
required. When we need all of the tiles in priority order, we use the
all queue. The reason for the split is that the required tiles can
be much simpler to get.

R=reveman, danakj

Committed: https://crrev.com/b4040632791d631fe532edac2ba35ed3a0112c47
Cr-Commit-Position: refs/heads/master@{#312871}

[vmpstr, 2015-01-22 01:26:15]

Please take a look.

[danakj, 2015-01-22 20:24:16]

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue.cc (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue.cc:29: return queue.Pass();
is pass needed here..?

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue.h (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue.h:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
don't change year on existing files

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue_all.h (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue_all.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
update the year in new files

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue_all.h:72: };
DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager.cc...
cc/resources/tile_manager.cc:436: required_for_draw_queue.reset(
why not queue =

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager_un...
File cc/resources/tile_manager_unittest.cc (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager_un...
cc/resources/tile_manager_unittest.cc:172:
queue.reset(host_impl_.BuildRasterQueue(SMOOTHNESS_TAKES_PRIORITY,
why not queue =

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager_un...
cc/resources/tile_manager_unittest.cc:191: queue.reset(
dittos throughout

[vmpstr, 2015-01-22 22:44:35]

PTAL.

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue.cc (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue.cc:29: return queue.Pass();
On 2015/01/22 20:24:15, danakj wrote:
> is pass needed here..?

Yes. If the types matched exactly, I wouldn't have to put it. However, the
compiler complains that it can't convert scoped_ptr<Foo> to scoped_ptr<Bar>
without the Pass. I think this stems from the fact that it first has to create a
temporary of scoped_ptr<RasterTilePriorityQueue> and initialize it with |queue|.
However, when it goes to do that |queue| is still an lvalue so it can't do it...

I've tested this with std::unique_ptr as well, and it's basically the same
thing. You need an std::move() if it's not exactly the same type.

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue.h (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue.h:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
On 2015/01/22 20:24:16, danakj wrote:
> don't change year on existing files

Heh, I moved raster_tile_priority_queue.h to raster_tile_priority_queue_all.h
and created a new one here, hence the year mix-up. I've changed it.

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue_all.h (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue_all.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2015/01/22 20:24:16, danakj wrote:
> update the year in new files

Done.

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue_all.h:72: };
On 2015/01/22 20:24:16, danakj wrote:
> DISALLOW_COPY_AND_ASSIGN

There's a disallow in the base class, does one need to be here as well?

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager.cc...
cc/resources/tile_manager.cc:436: required_for_draw_queue.reset(
On 2015/01/22 20:24:16, danakj wrote:
> why not queue = 

Done.

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager_un...
File cc/resources/tile_manager_unittest.cc (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager_un...
cc/resources/tile_manager_unittest.cc:172:
queue.reset(host_impl_.BuildRasterQueue(SMOOTHNESS_TAKES_PRIORITY,
On 2015/01/22 20:24:16, danakj wrote:
> why not queue = 

Done.

https://codereview.chromium.org/863013004/diff/1/cc/resources/tile_manager_un...
cc/resources/tile_manager_unittest.cc:191: queue.reset(
On 2015/01/22 20:24:16, danakj wrote:
> dittos throughout

Done.

[danakj, 2015-01-22 22:54:58]

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue_all.h (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue_all.h:72: };
On 2015/01/22 22:44:35, vmpstr wrote:
> On 2015/01/22 20:24:16, danakj wrote:
> > DISALLOW_COPY_AND_ASSIGN
> 
> There's a disallow in the base class, does one need to be here as well?

Put it everywhere you can :)

[vmpstr, 2015-01-22 23:01:11]

PTAL

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
File cc/resources/raster_tile_priority_queue_all.h (right):

https://codereview.chromium.org/863013004/diff/1/cc/resources/raster_tile_pri...
cc/resources/raster_tile_priority_queue_all.h:72: };
On 2015/01/22 22:54:58, danakj wrote:
> On 2015/01/22 22:44:35, vmpstr wrote:
> > On 2015/01/22 20:24:16, danakj wrote:
> > > DISALLOW_COPY_AND_ASSIGN
> > 
> > There's a disallow in the base class, does one need to be here as well?
> 
> Put it everywhere you can :)

Done.

[danakj, 2015-01-22 23:02:50]

LGTM

[vmpstr, 2015-01-22 23:09:52]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-01-22 23:11:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863013004/60001

[vmpstr, 2015-01-22 23:22:45]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-01-22 23:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863013004/80001

[commit-bot: I haz the power, 2015-01-23 01:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 01:26:53]

Exceeded time limit waiting for builds to trigger.

[vmpstr, 2015-01-23 17:51:33]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-01-23 17:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863013004/80001

[commit-bot: I haz the power, 2015-01-23 17:54:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-23 17:55:25]

Patchset 5 (id:??) landed as
https://crrev.com/b4040632791d631fe532edac2ba35ed3a0112c47
Cr-Commit-Position: refs/heads/master@{#312871}