Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: cc/resources/raster_tile_priority_queue_all.cc

Issue 863013004: cc: Split RasterTilePriorityQueue into required and all based on type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile fix Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/raster_tile_priority_queue_all.h ('k') | cc/resources/raster_tile_priority_queue_required.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/raster_tile_priority_queue_all.cc
diff --git a/cc/resources/raster_tile_priority_queue.cc b/cc/resources/raster_tile_priority_queue_all.cc
similarity index 81%
copy from cc/resources/raster_tile_priority_queue.cc
copy to cc/resources/raster_tile_priority_queue_all.cc
index 08862f68a6417e697a2e99997a6fc521a2611077..663dc45cd23d4bf05798829f649736b92137e100 100644
--- a/cc/resources/raster_tile_priority_queue.cc
+++ b/cc/resources/raster_tile_priority_queue_all.cc
@@ -1,8 +1,8 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "cc/resources/raster_tile_priority_queue.h"
+#include "cc/resources/raster_tile_priority_queue_all.h"
#include "cc/resources/tiling_set_raster_queue_all.h"
#include "cc/resources/tiling_set_raster_queue_required.h"
@@ -17,8 +17,8 @@ class RasterOrderComparator {
: tree_priority_(tree_priority) {}
bool operator()(
- const RasterTilePriorityQueue::PairedTilingSetQueue* a,
- const RasterTilePriorityQueue::PairedTilingSetQueue* b) const {
+ const RasterTilePriorityQueueAll::PairedTilingSetQueue* a,
+ const RasterTilePriorityQueueAll::PairedTilingSetQueue* b) const {
// Note that in this function, we have to return true if and only if
// a is strictly lower priority than b. Note that for the sake of
// completeness, empty queue is considered to have lowest priority.
@@ -129,56 +129,46 @@ WhichTree HigherPriorityTree(TreePriority tree_priority,
scoped_ptr<TilingSetRasterQueue> CreateTilingSetRasterQueue(
PictureLayerImpl* layer,
- TreePriority tree_priority,
- RasterTilePriorityQueue::Type type) {
+ TreePriority tree_priority) {
if (!layer)
return nullptr;
PictureLayerTilingSet* tiling_set = layer->picture_layer_tiling_set();
- if (type == RasterTilePriorityQueue::Type::ALL) {
- bool prioritize_low_res = tree_priority == SMOOTHNESS_TAKES_PRIORITY;
- return make_scoped_ptr(
- new TilingSetRasterQueueAll(tiling_set, prioritize_low_res));
- }
- return make_scoped_ptr(new TilingSetRasterQueueRequired(tiling_set, type));
+ bool prioritize_low_res = tree_priority == SMOOTHNESS_TAKES_PRIORITY;
+ return make_scoped_ptr(
+ new TilingSetRasterQueueAll(tiling_set, prioritize_low_res));
}
} // namespace
-RasterTilePriorityQueue::RasterTilePriorityQueue() {
+RasterTilePriorityQueueAll::RasterTilePriorityQueueAll() {
}
-RasterTilePriorityQueue::~RasterTilePriorityQueue() {
+RasterTilePriorityQueueAll::~RasterTilePriorityQueueAll() {
}
-void RasterTilePriorityQueue::Build(
+void RasterTilePriorityQueueAll::Build(
const std::vector<PictureLayerImpl::Pair>& paired_layers,
- TreePriority tree_priority,
- Type type) {
+ TreePriority tree_priority) {
tree_priority_ = tree_priority;
for (std::vector<PictureLayerImpl::Pair>::const_iterator it =
paired_layers.begin();
- it != paired_layers.end();
- ++it) {
+ it != paired_layers.end(); ++it) {
paired_queues_.push_back(
- make_scoped_ptr(new PairedTilingSetQueue(*it, tree_priority_, type)));
+ make_scoped_ptr(new PairedTilingSetQueue(*it, tree_priority_)));
}
paired_queues_.make_heap(RasterOrderComparator(tree_priority_));
}
-void RasterTilePriorityQueue::Reset() {
- paired_queues_.clear();
-}
-
-bool RasterTilePriorityQueue::IsEmpty() const {
+bool RasterTilePriorityQueueAll::IsEmpty() const {
return paired_queues_.empty() || paired_queues_.front()->IsEmpty();
}
-Tile* RasterTilePriorityQueue::Top() {
+Tile* RasterTilePriorityQueueAll::Top() {
DCHECK(!IsEmpty());
return paired_queues_.front()->Top(tree_priority_);
}
-void RasterTilePriorityQueue::Pop() {
+void RasterTilePriorityQueueAll::Pop() {
DCHECK(!IsEmpty());
paired_queues_.pop_heap(RasterOrderComparator(tree_priority_));
@@ -187,33 +177,17 @@ void RasterTilePriorityQueue::Pop() {
paired_queues_.push_heap(RasterOrderComparator(tree_priority_));
}
-RasterTilePriorityQueue::PairedTilingSetQueue::PairedTilingSetQueue() {
+RasterTilePriorityQueueAll::PairedTilingSetQueue::PairedTilingSetQueue() {
}
-RasterTilePriorityQueue::PairedTilingSetQueue::PairedTilingSetQueue(
+RasterTilePriorityQueueAll::PairedTilingSetQueue::PairedTilingSetQueue(
const PictureLayerImpl::Pair& layer_pair,
- TreePriority tree_priority,
- Type type)
- : has_both_layers_(false) {
- switch (type) {
- case RasterTilePriorityQueue::Type::ALL:
- has_both_layers_ = layer_pair.active && layer_pair.pending;
- active_queue_ =
- CreateTilingSetRasterQueue(layer_pair.active, tree_priority, type);
- pending_queue_ =
- CreateTilingSetRasterQueue(layer_pair.pending, tree_priority, type);
- break;
- case RasterTilePriorityQueue::Type::REQUIRED_FOR_ACTIVATION:
- pending_queue_ =
- CreateTilingSetRasterQueue(layer_pair.pending, tree_priority, type);
- break;
- case RasterTilePriorityQueue::Type::REQUIRED_FOR_DRAW:
- active_queue_ =
- CreateTilingSetRasterQueue(layer_pair.active, tree_priority, type);
- break;
- }
- DCHECK_IMPLIES(has_both_layers_, active_queue_ && pending_queue_);
-
+ TreePriority tree_priority)
+ : active_queue_(
+ CreateTilingSetRasterQueue(layer_pair.active, tree_priority)),
+ pending_queue_(
+ CreateTilingSetRasterQueue(layer_pair.pending, tree_priority)),
+ has_both_layers_(layer_pair.active && layer_pair.pending) {
SkipTilesReturnedByTwin(tree_priority);
TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
@@ -221,18 +195,18 @@ RasterTilePriorityQueue::PairedTilingSetQueue::PairedTilingSetQueue(
TRACE_EVENT_SCOPE_THREAD, "state", StateAsValue());
}
-RasterTilePriorityQueue::PairedTilingSetQueue::~PairedTilingSetQueue() {
+RasterTilePriorityQueueAll::PairedTilingSetQueue::~PairedTilingSetQueue() {
TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
"PairedTilingSetQueue::~PairedTilingSetQueue",
TRACE_EVENT_SCOPE_THREAD, "state", StateAsValue());
}
-bool RasterTilePriorityQueue::PairedTilingSetQueue::IsEmpty() const {
+bool RasterTilePriorityQueueAll::PairedTilingSetQueue::IsEmpty() const {
return (!active_queue_ || active_queue_->IsEmpty()) &&
(!pending_queue_ || pending_queue_->IsEmpty());
}
-Tile* RasterTilePriorityQueue::PairedTilingSetQueue::Top(
+Tile* RasterTilePriorityQueueAll::PairedTilingSetQueue::Top(
TreePriority tree_priority) {
DCHECK(!IsEmpty());
@@ -246,7 +220,7 @@ Tile* RasterTilePriorityQueue::PairedTilingSetQueue::Top(
return tile;
}
-void RasterTilePriorityQueue::PairedTilingSetQueue::Pop(
+void RasterTilePriorityQueueAll::PairedTilingSetQueue::Pop(
TreePriority tree_priority) {
DCHECK(!IsEmpty());
@@ -263,7 +237,7 @@ void RasterTilePriorityQueue::PairedTilingSetQueue::Pop(
DCHECK(IsEmpty() || Top(tree_priority));
}
-void RasterTilePriorityQueue::PairedTilingSetQueue::SkipTilesReturnedByTwin(
+void RasterTilePriorityQueueAll::PairedTilingSetQueue::SkipTilesReturnedByTwin(
TreePriority tree_priority) {
if (!has_both_layers_)
return;
@@ -291,7 +265,8 @@ void RasterTilePriorityQueue::PairedTilingSetQueue::SkipTilesReturnedByTwin(
}
}
-WhichTree RasterTilePriorityQueue::PairedTilingSetQueue::NextTileIteratorTree(
+WhichTree
+RasterTilePriorityQueueAll::PairedTilingSetQueue::NextTileIteratorTree(
TreePriority tree_priority) const {
DCHECK(!IsEmpty());
@@ -307,7 +282,7 @@ WhichTree RasterTilePriorityQueue::PairedTilingSetQueue::NextTileIteratorTree(
}
scoped_refptr<base::debug::ConvertableToTraceFormat>
-RasterTilePriorityQueue::PairedTilingSetQueue::StateAsValue() const {
+RasterTilePriorityQueueAll::PairedTilingSetQueue::StateAsValue() const {
scoped_refptr<base::debug::TracedValue> state =
new base::debug::TracedValue();
« no previous file with comments | « cc/resources/raster_tile_priority_queue_all.h ('k') | cc/resources/raster_tile_priority_queue_required.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698