cc: Split RasterTilePriorityQueue into required and all based on type.

cc/resources/raster_tile_priority_queue_all.cc

-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "cc/resources/raster_tile_priority_queue.h"
+#include "cc/resources/raster_tile_priority_queue_all.h"
 
 #include "cc/resources/tiling_set_raster_queue_all.h"
 #include "cc/resources/tiling_set_raster_queue_required.h"
 
 namespace cc {
 
 namespace {
 
 class RasterOrderComparator {
  public:
   explicit RasterOrderComparator(TreePriority tree_priority)
       : tree_priority_(tree_priority) {}
 
   bool operator()(
-      const RasterTilePriorityQueue::PairedTilingSetQueue* a,
-      const RasterTilePriorityQueue::PairedTilingSetQueue* b) const {
+      const RasterTilePriorityQueueAll::PairedTilingSetQueue* a,
+      const RasterTilePriorityQueueAll::PairedTilingSetQueue* b) const {
     // Note that in this function, we have to return true if and only if
     // a is strictly lower priority than b. Note that for the sake of
     // completeness, empty queue is considered to have lowest priority.
     if (a->IsEmpty() || b->IsEmpty())
       return b->IsEmpty() < a->IsEmpty();
 
     WhichTree a_tree = a->NextTileIteratorTree(tree_priority_);
     const TilingSetRasterQueue* a_queue =
         a_tree == ACTIVE_TREE ? a->active_queue() : a->pending_queue();
 
@@ skipping 90 matching lines @@
       return PENDING_TREE;
     }
     default:
       NOTREACHED();
       return ACTIVE_TREE;
   }
 }
 
 scoped_ptr<TilingSetRasterQueue> CreateTilingSetRasterQueue(
     PictureLayerImpl* layer,
-    TreePriority tree_priority,
-    RasterTilePriorityQueue::Type type) {
+    TreePriority tree_priority) {
   if (!layer)
     return nullptr;
   PictureLayerTilingSet* tiling_set = layer->picture_layer_tiling_set();
-  if (type == RasterTilePriorityQueue::Type::ALL) {
-    bool prioritize_low_res = tree_priority == SMOOTHNESS_TAKES_PRIORITY;
-    return make_scoped_ptr(
-        new TilingSetRasterQueueAll(tiling_set, prioritize_low_res));
-  }
-  return make_scoped_ptr(new TilingSetRasterQueueRequired(tiling_set, type));
+  bool prioritize_low_res = tree_priority == SMOOTHNESS_TAKES_PRIORITY;
+  return make_scoped_ptr(
+      new TilingSetRasterQueueAll(tiling_set, prioritize_low_res));
 }
 
 }  // namespace
 
-RasterTilePriorityQueue::RasterTilePriorityQueue() {
+RasterTilePriorityQueueAll::RasterTilePriorityQueueAll() {
 }
 
-RasterTilePriorityQueue::~RasterTilePriorityQueue() {
+RasterTilePriorityQueueAll::~RasterTilePriorityQueueAll() {
 }
 
-void RasterTilePriorityQueue::Build(
+void RasterTilePriorityQueueAll::Build(
     const std::vector<PictureLayerImpl::Pair>& paired_layers,
-    TreePriority tree_priority,
-    Type type) {
+    TreePriority tree_priority) {
   tree_priority_ = tree_priority;
   for (std::vector<PictureLayerImpl::Pair>::const_iterator it =
            paired_layers.begin();
-       it != paired_layers.end();
-       ++it) {
+       it != paired_layers.end(); ++it) {
     paired_queues_.push_back(
-        make_scoped_ptr(new PairedTilingSetQueue(*it, tree_priority_, type)));
+        make_scoped_ptr(new PairedTilingSetQueue(*it, tree_priority_)));
   }
   paired_queues_.make_heap(RasterOrderComparator(tree_priority_));
 }
 
-void RasterTilePriorityQueue::Reset() {
-  paired_queues_.clear();
-}
-
-bool RasterTilePriorityQueue::IsEmpty() const {
+bool RasterTilePriorityQueueAll::IsEmpty() const {
   return paired_queues_.empty() || paired_queues_.front()->IsEmpty();
 }
 
-Tile* RasterTilePriorityQueue::Top() {
+Tile* RasterTilePriorityQueueAll::Top() {
   DCHECK(!IsEmpty());
   return paired_queues_.front()->Top(tree_priority_);
 }
 
-void RasterTilePriorityQueue::Pop() {
+void RasterTilePriorityQueueAll::Pop() {
   DCHECK(!IsEmpty());
 
   paired_queues_.pop_heap(RasterOrderComparator(tree_priority_));
   PairedTilingSetQueue* paired_queue = paired_queues_.back();
   paired_queue->Pop(tree_priority_);
   paired_queues_.push_heap(RasterOrderComparator(tree_priority_));
 }
 
-RasterTilePriorityQueue::PairedTilingSetQueue::PairedTilingSetQueue() {
+RasterTilePriorityQueueAll::PairedTilingSetQueue::PairedTilingSetQueue() {
 }
 
-RasterTilePriorityQueue::PairedTilingSetQueue::PairedTilingSetQueue(
+RasterTilePriorityQueueAll::PairedTilingSetQueue::PairedTilingSetQueue(
     const PictureLayerImpl::Pair& layer_pair,
-    TreePriority tree_priority,
-    Type type)
-    : has_both_layers_(false) {
-  switch (type) {
-    case RasterTilePriorityQueue::Type::ALL:
-      has_both_layers_ = layer_pair.active && layer_pair.pending;
-      active_queue_ =
-          CreateTilingSetRasterQueue(layer_pair.active, tree_priority, type);
-      pending_queue_ =
-          CreateTilingSetRasterQueue(layer_pair.pending, tree_priority, type);
-      break;
-    case RasterTilePriorityQueue::Type::REQUIRED_FOR_ACTIVATION:
-      pending_queue_ =
-          CreateTilingSetRasterQueue(layer_pair.pending, tree_priority, type);
-      break;
-    case RasterTilePriorityQueue::Type::REQUIRED_FOR_DRAW:
-      active_queue_ =
-          CreateTilingSetRasterQueue(layer_pair.active, tree_priority, type);
-      break;
-  }
-  DCHECK_IMPLIES(has_both_layers_, active_queue_ && pending_queue_);
-
+    TreePriority tree_priority)
+    : active_queue_(
+          CreateTilingSetRasterQueue(layer_pair.active, tree_priority)),
+      pending_queue_(
+          CreateTilingSetRasterQueue(layer_pair.pending, tree_priority)),
+      has_both_layers_(layer_pair.active && layer_pair.pending) {
   SkipTilesReturnedByTwin(tree_priority);
 
   TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
                        "PairedTilingSetQueue::PairedTilingSetQueue",
                        TRACE_EVENT_SCOPE_THREAD, "state", StateAsValue());
 }
 
-RasterTilePriorityQueue::PairedTilingSetQueue::~PairedTilingSetQueue() {
+RasterTilePriorityQueueAll::PairedTilingSetQueue::~PairedTilingSetQueue() {
   TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
                        "PairedTilingSetQueue::~PairedTilingSetQueue",
                        TRACE_EVENT_SCOPE_THREAD, "state", StateAsValue());
 }
 
-bool RasterTilePriorityQueue::PairedTilingSetQueue::IsEmpty() const {
+bool RasterTilePriorityQueueAll::PairedTilingSetQueue::IsEmpty() const {
   return (!active_queue_ || active_queue_->IsEmpty()) &&
          (!pending_queue_ || pending_queue_->IsEmpty());
 }
 
-Tile* RasterTilePriorityQueue::PairedTilingSetQueue::Top(
+Tile* RasterTilePriorityQueueAll::PairedTilingSetQueue::Top(
     TreePriority tree_priority) {
   DCHECK(!IsEmpty());
 
   WhichTree next_tree = NextTileIteratorTree(tree_priority);
   TilingSetRasterQueue* next_queue =
       next_tree == ACTIVE_TREE ? active_queue_.get() : pending_queue_.get();
   DCHECK(next_queue && !next_queue->IsEmpty());
   Tile* tile = next_queue->Top();
   DCHECK(returned_tiles_for_debug_.find(tile) ==
          returned_tiles_for_debug_.end());
   return tile;
 }
 
-void RasterTilePriorityQueue::PairedTilingSetQueue::Pop(
+void RasterTilePriorityQueueAll::PairedTilingSetQueue::Pop(
     TreePriority tree_priority) {
   DCHECK(!IsEmpty());
 
   WhichTree next_tree = NextTileIteratorTree(tree_priority);
   TilingSetRasterQueue* next_queue =
       next_tree == ACTIVE_TREE ? active_queue_.get() : pending_queue_.get();
   DCHECK(next_queue && !next_queue->IsEmpty());
   DCHECK(returned_tiles_for_debug_.insert(next_queue->Top()).second);
   next_queue->Pop();
 
   SkipTilesReturnedByTwin(tree_priority);
 
   // If no empty, use Top to do DCHECK the next iterator.
   DCHECK(IsEmpty() || Top(tree_priority));
 }
 
-void RasterTilePriorityQueue::PairedTilingSetQueue::SkipTilesReturnedByTwin(
+void RasterTilePriorityQueueAll::PairedTilingSetQueue::SkipTilesReturnedByTwin(
     TreePriority tree_priority) {
   if (!has_both_layers_)
     return;
 
   // We have both layers (active and pending) thus we can encounter shared
   // tiles twice (from the active iterator and from the pending iterator).
   while (!IsEmpty()) {
     WhichTree next_tree = NextTileIteratorTree(tree_priority);
     TilingSetRasterQueue* next_queue =
         next_tree == ACTIVE_TREE ? active_queue_.get() : pending_queue_.get();
     DCHECK(next_queue && !next_queue->IsEmpty());
 
     // Accept all non-shared tiles.
     const Tile* tile = next_queue->Top();
     if (!tile->is_shared())
       break;
 
     // Accept a shared tile if the next tree is the higher priority one
     // corresponding the iterator (active or pending) which usually (but due
     // to spiral iterators not always) returns the shared tile first.
     if (next_tree == HigherPriorityTree(tree_priority, nullptr, nullptr, tile))
       break;
 
     next_queue->Pop();
   }
 }
 
-WhichTree RasterTilePriorityQueue::PairedTilingSetQueue::NextTileIteratorTree(
+WhichTree
+RasterTilePriorityQueueAll::PairedTilingSetQueue::NextTileIteratorTree(
     TreePriority tree_priority) const {
   DCHECK(!IsEmpty());
 
   // If we only have one queue with tiles, return it.
   if (!active_queue_ || active_queue_->IsEmpty())
     return PENDING_TREE;
   if (!pending_queue_ || pending_queue_->IsEmpty())
     return ACTIVE_TREE;
 
   // Now both iterators have tiles, so we have to decide based on tree priority.
   return HigherPriorityTree(tree_priority, active_queue_.get(),
                             pending_queue_.get(), nullptr);
 }
 
 scoped_refptr<base::debug::ConvertableToTraceFormat>
-RasterTilePriorityQueue::PairedTilingSetQueue::StateAsValue() const {
+RasterTilePriorityQueueAll::PairedTilingSetQueue::StateAsValue() const {
   scoped_refptr<base::debug::TracedValue> state =
       new base::debug::TracedValue();
 
   bool active_queue_has_tile = active_queue_ && !active_queue_->IsEmpty();
   TilePriority::PriorityBin active_priority_bin = TilePriority::EVENTUALLY;
   TilePriority::PriorityBin pending_priority_bin = TilePriority::EVENTUALLY;
   if (active_queue_has_tile) {
     active_priority_bin =
         active_queue_->Top()->priority(ACTIVE_TREE).priority_bin;
     pending_priority_bin =
@@ skipping 18 matching lines @@
 
   state->BeginDictionary("pending_queue");
   state->SetBoolean("has_tile", active_queue_has_tile);
   state->SetInteger("active_priority_bin", active_priority_bin);
   state->SetInteger("pending_priority_bin", pending_priority_bin);
   state->EndDictionary();
   return state;
 }
 
 }  // namespace cc