Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 862543003: Table headers are not retrieved properly by Accessibility API (Closed)

Created:
5 years, 11 months ago by k.czech
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Table headers are not retrieved properly by Accessibility API Accessibility API for retrieving table headers do not work correctly. It returns wrong number of headers and it's not suitable to the current logic that determines table headers. BUG=450255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188747

Patch Set 1 #

Total comments: 1

Patch Set 2 : Minor fixes, correct comment and very small refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -24 lines) Patch
M LayoutTests/accessibility/table-headers.html View 3 chunks +165 lines, -6 lines 0 comments Download
M LayoutTests/accessibility/table-headers-expected.txt View 1 chunk +63 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXTable.cpp View 2 chunks +5 lines, -13 lines 0 comments Download
M Source/modules/accessibility/AXTableCell.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXTableColumn.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTableColumn.cpp View 1 2 chunks +34 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTableRow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTableRow.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
k.czech
5 years, 11 months ago (2015-01-20 16:42:02 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/862543003/diff/1/Source/modules/accessibility/AXTableColumn.h File Source/modules/accessibility/AXTableColumn.h (right): https://codereview.chromium.org/862543003/diff/1/Source/modules/accessibility/AXTableColumn.h#newcode51 Source/modules/accessibility/AXTableColumn.h:51: // retrieves the "column" headers (th, scope) from ...
5 years, 11 months ago (2015-01-21 07:12:30 UTC) #3
k.czech
On 2015/01/21 07:12:30, dmazzoni wrote: > lgtm > > https://codereview.chromium.org/862543003/diff/1/Source/modules/accessibility/AXTableColumn.h > File Source/modules/accessibility/AXTableColumn.h (right): > ...
5 years, 11 months ago (2015-01-21 13:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862543003/20001
5 years, 11 months ago (2015-01-21 13:51:18 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 15:04:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188747

Powered by Google App Engine
This is Rietveld 408576698