Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: Source/modules/accessibility/AXTableCell.h

Issue 862543003: Table headers are not retrieved properly by Accessibility API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Minor fixes, correct comment and very small refactoring Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXTable.cpp ('k') | Source/modules/accessibility/AXTableColumn.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 static PassRefPtr<AXTableCell> create(RenderObject*, AXObjectCacheImpl*); 44 static PassRefPtr<AXTableCell> create(RenderObject*, AXObjectCacheImpl*);
45 virtual ~AXTableCell(); 45 virtual ~AXTableCell();
46 46
47 virtual bool isTableCell() const override final; 47 virtual bool isTableCell() const override final;
48 48
49 // fills in the start location and row span of cell 49 // fills in the start location and row span of cell
50 virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange); 50 virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange);
51 // fills in the start location and column span of cell 51 // fills in the start location and column span of cell
52 virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange); 52 virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange);
53 53
54 AccessibilityRole scanToDecideHeaderRole();
54 protected: 55 protected:
55 virtual AXObject* parentTable() const; 56 virtual AXObject* parentTable() const;
56 int m_rowIndex; 57 int m_rowIndex;
57 virtual AccessibilityRole determineAccessibilityRole() override final; 58 virtual AccessibilityRole determineAccessibilityRole() override final;
58 59
59 private: 60 private:
60 bool isTableHeaderCell() const; 61 bool isTableHeaderCell() const;
61 bool isRowHeaderCell() const; 62 bool isRowHeaderCell() const;
62 bool isColumnHeaderCell() const; 63 bool isColumnHeaderCell() const;
63 64
64 AccessibilityRole scanToDecideHeaderRole();
65 // If a table cell is not exposed as a table cell, a TH element can serve as its title UI element. 65 // If a table cell is not exposed as a table cell, a TH element can serve as its title UI element.
66 virtual AXObject* titleUIElement() const override final; 66 virtual AXObject* titleUIElement() const override final;
67 virtual bool exposesTitleUIElement() const override final { return true; } 67 virtual bool exposesTitleUIElement() const override final { return true; }
68 virtual bool computeAccessibilityIsIgnored() const override final; 68 virtual bool computeAccessibilityIsIgnored() const override final;
69 }; 69 };
70 70
71 DEFINE_AX_OBJECT_TYPE_CASTS(AXTableCell, isTableCell()); 71 DEFINE_AX_OBJECT_TYPE_CASTS(AXTableCell, isTableCell());
72 72
73 } // namespace blink 73 } // namespace blink
74 74
75 #endif // AXTableCell_h 75 #endif // AXTableCell_h
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXTable.cpp ('k') | Source/modules/accessibility/AXTableColumn.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698