Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Side by Side Diff: Source/modules/accessibility/AXTableRow.cpp

Issue 862543003: Table headers are not retrieved properly by Accessibility API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Minor fixes, correct comment and very small refactoring Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXTableRow.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 if (!cellRenderer) 119 if (!cellRenderer)
120 return 0; 120 return 0;
121 121
122 Node* cellNode = cellRenderer->node(); 122 Node* cellNode = cellRenderer->node();
123 if (!cellNode || !cellNode->hasTagName(thTag)) 123 if (!cellNode || !cellNode->hasTagName(thTag))
124 return 0; 124 return 0;
125 125
126 return cell; 126 return cell;
127 } 127 }
128 128
129 void AXTableRow::headerObjectsForRow(AccessibilityChildrenVector& headers)
130 {
131 if (!m_renderer || !m_renderer->isTableRow())
132 return;
133
134 AccessibilityChildrenVector rowChildren = children();
135 unsigned childrenCount = rowChildren.size();
136 for (unsigned i = 0; i < childrenCount; i++) {
137 AXObject* cell = rowChildren[i].get();
138 if (!cell->isTableCell())
139 continue;
140
141 if (toAXTableCell(cell)->scanToDecideHeaderRole() == RowHeaderRole)
142 headers.append(cell);
143 }
144 }
145
129 } // namespace blink 146 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXTableRow.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698