Fix referrer policy handling in service workers

Fix referrer policy handling in service workers

BUG=450589
R=mkwst@chromium.org,jkarlin@chromium.org

Committed: https://crrev.com/73fc00d1a4a2006dafc077cdde45a0a69d4c1d13
Cr-Commit-Position: refs/heads/master@{#313072}

[Mike West, 2015-01-21 16:13:50]

This is a good change. LGTM % one question.

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_url_request_job.cc (right):

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_url_request_job.cc:407:
net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);
Why is the CHECK here safe?

[jochen (gone - plz use gerrit), 2015-01-21 16:15:47]

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_url_request_job.cc (right):

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_url_request_job.cc:407:
net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);
On 2015/01/21 at 16:13:50, Mike West wrote:
> Why is the CHECK here safe?

If I thought it was safe, I'd make it a DCHECK(). However, when it holds, using
the default policy is fine..

[jkarlin, 2015-01-21 16:43:47]

Could you add includes for Referrer() in the various files?

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_url_request_job.cc (right):

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_url_request_job.cc:407:
net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);
On 2015/01/21 16:15:47, jochen (slow) wrote:
> On 2015/01/21 at 16:13:50, Mike West wrote:
> > Why is the CHECK here safe?
> 
> If I thought it was safe, I'd make it a DCHECK(). However, when it holds,
using
> the default policy is fine..

Certainly seems dangerous to assume the referrer policy. Under what
circumstances might info be nullptr?

[jochen (gone - plz use gerrit), 2015-01-21 18:39:42]

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_url_request_job.cc (right):

https://codereview.chromium.org/862053002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_url_request_job.cc:407:
net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);
On 2015/01/21 16:43:47, jkarlin wrote:
> On 2015/01/21 16:15:47, jochen (slow) wrote:
> > On 2015/01/21 at 16:13:50, Mike West wrote:
> > > Why is the CHECK here safe?
> > 
> > If I thought it was safe, I'd make it a DCHECK(). However, when it holds,
> using
> > the default policy is fine..
> 
> Certainly seems dangerous to assume the referrer policy. Under what
> circumstances might info be nullptr?

info is null if the request came from the browser (should not happen) or during
unit tests (in which case assuming that the request has the default policy is
fine apparently)

The CLEAR_REFERRER... policy is the equivalent of WebReferrerPolicyDefault

[jochen (gone - plz use gerrit), 2015-01-23 10:07:31]

added includes, ptal

[jkarlin, 2015-01-26 12:41:31]

On 2015/01/23 10:07:31, jochen (slow) wrote:
> added includes, ptal

lgtm

[jochen (gone - plz use gerrit), 2015-01-26 12:42:20]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-01-26 12:42:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/862053002/20001

[commit-bot: I haz the power, 2015-01-26 13:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-26 13:01:53]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jochen (gone - plz use gerrit), 2015-01-26 14:40:01]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-01-26 14:41:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/862053002/20001

[commit-bot: I haz the power, 2015-01-26 15:19:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-26 15:20:53]

Patchset 2 (id:??) landed as
https://crrev.com/73fc00d1a4a2006dafc077cdde45a0a69d4c1d13
Cr-Commit-Position: refs/heads/master@{#313072}