Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2461)

Unified Diff: content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc

Issue 862053002: Fix referrer policy handling in service workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
diff --git a/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc b/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
index e88c69f3e7bd646913a69365f4845dc4dcef4e64..423de5a1740f710ad099e6f6697674a3359b92d7 100644
--- a/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
+++ b/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
@@ -12,6 +12,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/utf_string_conversions.h"
#include "content/common/service_worker/service_worker_messages.h"
+#include "content/public/common/referrer.h"
#include "content/public/renderer/render_thread.h"
#include "content/renderer/service_worker/service_worker_script_context.h"
#include "third_party/WebKit/public/platform/WebHTTPHeaderVisitor.h"
@@ -52,10 +53,10 @@ ServiceWorkerFetchRequest FetchRequestFromWebRequest(
ServiceWorkerHeaderMap headers;
web_request.visitHTTPHeaderFields(MakeHeaderVisitor(&headers).get());
- return ServiceWorkerFetchRequest(web_request.url(),
- base::UTF16ToASCII(web_request.method()),
- headers, web_request.referrerUrl(),
- web_request.isReload());
+ return ServiceWorkerFetchRequest(
+ web_request.url(), base::UTF16ToASCII(web_request.method()), headers,
+ Referrer(web_request.referrerUrl(), web_request.referrerPolicy()),
+ web_request.isReload());
}
void PopulateWebRequestFromFetchRequest(
@@ -69,8 +70,8 @@ void PopulateWebRequestFromFetchRequest(
web_request->setHeader(base::ASCIIToUTF16(i->first),
base::ASCIIToUTF16(i->second));
}
- web_request->setReferrer(base::ASCIIToUTF16(request.referrer.spec()),
- blink::WebReferrerPolicy::WebReferrerPolicyNever);
+ web_request->setReferrer(base::ASCIIToUTF16(request.referrer.url.spec()),
+ request.referrer.policy);
web_request->setIsReload(request.is_reload);
}

Powered by Google App Engine
This is Rietveld 408576698