Fix referrer policy handling in service workers

content/browser/service_worker/service_worker_url_request_job.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_url_request_job.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 376 matching lines @@
   request->url = request_->url();
   request->method = request_->method();
   const net::HttpRequestHeaders& headers = request_->extra_request_headers();
   for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();) {
     if (ServiceWorkerContext::IsExcludedHeaderNameForFetchEvent(it.name()))
       continue;
     request->headers[it.name()] = it.value();
   }
   request->blob_uuid = blob_uuid;
   request->blob_size = blob_size;
-  request->referrer = GURL(request_->referrer());
   request->credentials_mode = credentials_mode_;
   const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request_);
   if (info) {
     request->is_reload = ui::PageTransitionCoreTypeIs(
         info->GetPageTransition(), ui::PAGE_TRANSITION_RELOAD);
+    request->referrer =
+        Referrer(GURL(request_->referrer()), info->GetReferrerPolicy());
+  } else {
+    CHECK(
+        request_->referrer_policy() ==
+        net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);

[Mike West, 2015/01/21 16:13:50]

Why is the CHECK here safe?

[jochen (gone - plz use gerrit), 2015/01/21 16:15:47]

If I thought it was safe, I'd make it a DCHECK(). However, when it holds, using
the default policy is fine..

[jkarlin, 2015/01/21 16:43:47]

Certainly seems dangerous to assume the referrer policy. Under what
circumstances might info be nullptr?

[jochen (gone - plz use gerrit), 2015/01/21 18:39:42]

info is null if the request came from the browser (should not happen) or during
unit tests (in which case assuming that the request has the default policy is
fine apparently)

The CLEAR_REFERRER... policy is the equivalent of WebReferrerPolicyDefault

+    request->referrer =
+        Referrer(GURL(request_->referrer()), blink::WebReferrerPolicyDefault);
   }
   return request.Pass();
 }
 
 bool ServiceWorkerURLRequestJob::CreateRequestBodyBlob(std::string* blob_uuid,
                                                        uint64* blob_size) {
   if (!body_.get() || !blob_storage_context_)
     return false;
 
   std::vector<const ResourceRequestBody::Element*> resolved_elements;
@@ skipping 206 matching lines @@
   }
   if (!waiting_stream_url_.is_empty()) {
     StreamRegistry* stream_registry =
         GetStreamContextForResourceContext(resource_context_)->registry();
     stream_registry->RemoveRegisterObserver(waiting_stream_url_);
     stream_registry->AbortPendingStream(waiting_stream_url_);
   }
 }
 
 }  // namespace content